Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758859Ab3CYR6d (ORCPT ); Mon, 25 Mar 2013 13:58:33 -0400 Received: from mail-qc0-f170.google.com ([209.85.216.170]:44650 "EHLO mail-qc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758327Ab3CYR6c (ORCPT ); Mon, 25 Mar 2013 13:58:32 -0400 MIME-Version: 1.0 In-Reply-To: <1364210014.5053.2.camel@laptop> References: <1363949499-3728-1-git-send-email-eranian@google.com> <1363949499-3728-2-git-send-email-eranian@google.com> <1364210014.5053.2.camel@laptop> Date: Mon, 25 Mar 2013 18:58:31 +0100 Message-ID: Subject: Re: [PATCH v5 1/2] perf: use hrtimer for event multiplexing From: Stephane Eranian To: Peter Zijlstra Cc: LKML , "mingo@elte.hu" , "ak@linux.intel.com" , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 28 On Mon, Mar 25, 2013 at 12:13 PM, Peter Zijlstra wrote: > On Fri, 2013-03-22 at 11:51 +0100, Stephane Eranian wrote: >> +#define PERF_CPU_HRTIMER (1000 / HZ) >> +static enum hrtimer_restart perf_cpu_hrtimer_handler(struct hrtimer >> *hr) >> +{ >> + struct perf_cpu_context *cpuctx; >> + enum hrtimer_restart ret = HRTIMER_NORESTART; >> + unsigned long flags; >> + int rotations = 0; >> + >> + cpuctx = container_of(hr, struct perf_cpu_context, hrtimer); >> + >> + local_irq_save(flags); >> + >> + rotations = perf_rotate_context(cpuctx); >> + >> + local_irq_restore(flags); > > IIRC hrtimer callbacks are always ran with interrupts disabled.. not a > big deal though. I'll continue reading. I can create a V6 to remove this if necessary. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/