Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933081Ab3CYUk7 (ORCPT ); Mon, 25 Mar 2013 16:40:59 -0400 Received: from mga09.intel.com ([134.134.136.24]:62244 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758299Ab3CYUk6 (ORCPT ); Mon, 25 Mar 2013 16:40:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,907,1355126400"; d="scan'208";a="284391002" Subject: Re: [PATCH 06/11] Create module providing optimized SHA256 routines using SSSE3, AVX or AVX2 instructions. From: Tim Chen To: Jussi Kivilinna Cc: Herbert Xu , "H. Peter Anvin" , "David S.Miller" , Kirk Yap , David Cote , James Guilford , Wajdi Feghali , linux-kernel , linux-crypto@vger.kernel.org In-Reply-To: <514F75BB.3080501@iki.fi> References: <1363987761.8972.60.camel@schen9-DESK> <514F75BB.3080501@iki.fi> Content-Type: text/plain; charset="UTF-8" Date: Mon, 25 Mar 2013 13:40:40 -0700 Message-ID: <1364244040.8972.71.camel@schen9-DESK> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 37 On Sun, 2013-03-24 at 23:52 +0200, Jussi Kivilinna wrote: > On 22.03.2013 23:29, Tim Chen wrote: > > We added glue code and config options to create crypto > > module that uses SSE/AVX/AVX2 optimized SHA256 x86_64 assembly routines. > > > > Signed-off-by: Tim Chen > > ..snip.. > > > diff --git a/arch/x86/crypto/sha256_ssse3_glue.c b/arch/x86/crypto/sha256_ssse3_glue.c > > new file mode 100644 > > index 0000000..5876a19 > > --- /dev/null > > +++ b/arch/x86/crypto/sha256_ssse3_glue.c > > ..snip.. > > > +static int __init sha256_ssse3_mod_init(void) > > +{ > > + /* test for SSE3 first */ > > + if (cpu_has_xmm3) > > + sha256_transform_asm = sha256_transform_ssse3; > > + > > This causes OOPS on my computer. Maybe use 'cpu_has_ssse3' instead? > Thanks and appreciate your feedback. I'll be sending an update of the patch series to address the issues. Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/