Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933204Ab3CYVb4 (ORCPT ); Mon, 25 Mar 2013 17:31:56 -0400 Received: from relay2.sgi.com ([192.48.179.30]:56660 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932801Ab3CYVbz (ORCPT ); Mon, 25 Mar 2013 17:31:55 -0400 Message-ID: <5150C248.7020407@sgi.com> Date: Mon, 25 Mar 2013 14:31:52 -0700 From: Mike Travis User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Jason Wessel CC: Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Andrew Morton , kgdb-bugreport@lists.sourceforge.net, x86@kernel.org, linux-kernel@vger.kernel.org, Tim Bird Subject: Re: [PATCH 03/15] KDB: up the default LINES value References: <20130325185007.321022858@gulag1.americas.sgi.com> <20130325185007.776886654@gulag1.americas.sgi.com> <5150C01A.3030602@windriver.com> In-Reply-To: <5150C01A.3030602@windriver.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2206 Lines: 60 On 3/25/2013 2:22 PM, Jason Wessel wrote: > On 03/25/2013 01:50 PM, Mike Travis wrote: >> Currently the default for the # of lines displayed by the KDB pager >> is 24. This does not allow all of the lines for the entry messages, >> reg dump and process trace. Increase it to something more reasonable. >> > > > Unfortunately this is something that breaks compatibility with the > standard VGA console, so this patch will not be merged. > > Is it the case that your hardware specifies how many lines and columns > there are in the display? We have some hooks into the console VT code > to properly detect this but perhaps something is wrong there, or it is > only called in the KMS (kernel mode setting case). Example: > drivers/tty/vt/vt.c - look at con_debug_enter() > > Another option might be to add a variable which allows you to change > the default at compile time, but I would prefer to get the auto detect > code working properly if it is an option. > > Jason. Nah, this was more of an annoyance before I added the "system nmi" entry reason code, which changes the entry message to be more like it is for a requested entry (like sysreq 'g') than it is for a real error which dumps a ton of stuff. Our primary system console is a serial connection, so we can't use the VT stuff (though the VT console is an option). > > > >> Cc: Tim Bird >> Reviewed-by: Dimitri Sivanich >> Signed-off-by: Mike Travis >> --- >> kernel/debug/kdb/kdb_io.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux.orig/kernel/debug/kdb/kdb_io.c >> +++ linux/kernel/debug/kdb/kdb_io.c >> @@ -586,7 +586,7 @@ int vkdb_printf(const char *fmt, va_list >> >> diag = kdbgetintenv("LINES", &linecount); >> if (diag || linecount <= 1) >> - linecount = 24; >> + linecount = 60; >> >> diag = kdbgetintenv("COLUMNS", &colcount); >> if (diag || colcount <= 1) >> >> -- >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/