Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933816Ab3CYXze (ORCPT ); Mon, 25 Mar 2013 19:55:34 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:33712 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758209Ab3CYXzd (ORCPT ); Mon, 25 Mar 2013 19:55:33 -0400 Date: Mon, 25 Mar 2013 23:55:25 +0000 From: Matthew Garrett To: Dave Airlie Cc: Mantas =?utf-8?Q?Mikul=C4=97nas?= , Linus Torvalds , Matthew Garrett , Bjorn Helgaas , Seth Forshee , Linux Kernel Mailing List , Ben Skeggs Subject: Re: Regression: Screen turns off when booting in EFI mode Message-ID: <20130325235525.GA3423@srcf.ucam.org> References: <5126C3E1.80801@gmail.com> <513BACAC.9050800@gmail.com> <20130319195950.GA16828@srcf.ucam.org> <5148D5C8.2000701@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 27 On Tue, Mar 26, 2013 at 09:52:14AM +1000, Dave Airlie wrote: > >>> Because it's the only way to get the PCI ROM in some cases, like on > >>> pretty much all Apples with Radeons. Only using it if we have no other > >>> options probably makes sense, though. Something like this (entirely > >>> untested)? > >> > >> This looks reasonable. Mantas? > > > > It compiles, boots, and even makes the graphics card work again. > > So it looks good to me. > > https://bugzilla.redhat.com/show_bug.cgi?id=927451 > > popped up sounds like a regression caused by this. Sigh. I guess we need to figure out where it thinks it's getting that image from. The alternative is basically to go back to what Linus suggested, remove this from pci_map_rom() and add an explicit lookup to the video drivers. -- Matthew Garrett | mjg59@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/