Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933938Ab3CZCoq (ORCPT ); Mon, 25 Mar 2013 22:44:46 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:12686 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933865Ab3CZCom (ORCPT ); Mon, 25 Mar 2013 22:44:42 -0400 From: Yijing Wang To: Tony Luck CC: , Hanjun Guo , Yijing Wang Subject: [PATCH v5 3/5] PCI/AER: clean all untracked pci_ops_aer when rmmod aer_inject Date: Tue, 26 Mar 2013 10:43:37 +0800 Message-ID: <1364265819-6732-4-git-send-email-wangyijing@huawei.com> X-Mailer: git-send-email 1.7.11.msysgit.1 In-Reply-To: <1364265819-6732-1-git-send-email-wangyijing@huawei.com> References: <1364265819-6732-1-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.135.76.69] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2019 Lines: 62 When we do hot plug for pci devices that were injected aer errors, some newly created child buses' pci_ops will be assigned to pci_ops_aer. Aer_inject module will not track these pci_ops_aer(not list in pci_bus_ops_list),so we should clean all of these when rmmod aer_inject module. Reviewed-by: Huang Ying Signed-off-by: Yijing Wang --- drivers/pci/pcie/aer/aer_inject.c | 24 ++++++++++++++++++++++++ 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c index f499f01..4777c44 100644 --- a/drivers/pci/pcie/aer/aer_inject.c +++ b/drivers/pci/pcie/aer/aer_inject.c @@ -285,6 +285,29 @@ static void pci_bus_ops_init(struct pci_bus_ops *bus_ops, bus_ops->ops = ops; } +static void pci_clean_child_aer_ops(struct pci_bus *bus) +{ + struct pci_bus *child; + + list_for_each_entry(child, &bus->children, node) { + if (child->ops == &pci_ops_aer) + pci_bus_set_ops(child, bus->ops); + pci_clean_child_aer_ops(child); + } +} + +/* find pci_ops_aer from root bus, and replace it by parent bus's pci_ops. + * pci_ops of root bus won't be pci_ops_aer here*/ +static void clean_untracked_pci_ops_aer(void) +{ + struct pci_bus_ops *bus_ops; + + list_for_each_entry(bus_ops, &pci_bus_ops_list, list) { + if (pci_is_root_bus(bus_ops->bus)) + pci_clean_child_aer_ops(bus_ops->bus); + } +} + static int pci_bus_set_aer_ops(struct pci_bus *bus) { struct pci_ops *ops; @@ -546,6 +569,7 @@ static void __exit aer_inject_exit(void) list_for_each_entry(bus_ops, &pci_bus_ops_list, list) pci_bus_set_ops(bus_ops->bus, bus_ops->ops); + clean_untracked_pci_ops_aer(); while ((bus_ops = pci_bus_ops_pop())) kfree(bus_ops); -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/