Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934064Ab3CZGBg (ORCPT ); Tue, 26 Mar 2013 02:01:36 -0400 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:59821 "EHLO LGEMRELSE6Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933228Ab3CZGA6 (ORCPT ); Tue, 26 Mar 2013 02:00:58 -0400 X-AuditID: 9c930179-b7c78ae000000e4b-4f-51513997073e From: Joonsoo Kim To: Ingo Molnar , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Srivatsa Vaddagiri , Joonsoo Kim Subject: [PATCH v2 2/6] sched: explicitly cpu_idle_type checking in rebalance_domains() Date: Tue, 26 Mar 2013 15:01:36 +0900 Message-Id: <1364277700-7509-3-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1364277700-7509-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1364277700-7509-1-git-send-email-iamjoonsoo.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 33 After commit 88b8dac0, dst-cpu can be changed in load_balance(), then we can't know cpu_idle_type of dst-cpu when load_balance() return positive. So, add explicit cpu_idle_type checking. Cc: Srivatsa Vaddagiri Signed-off-by: Joonsoo Kim diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index f084069..9d693d0 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5506,10 +5506,10 @@ static void rebalance_domains(int cpu, enum cpu_idle_type idle) if (time_after_eq(jiffies, sd->last_balance + interval)) { if (load_balance(cpu, rq, sd, idle, &balance)) { /* - * We've pulled tasks over so either we're no - * longer idle. + * We've pulled tasks over so either we may + * be no longer idle. */ - idle = CPU_NOT_IDLE; + idle = idle_cpu(cpu) ? CPU_IDLE : CPU_NOT_IDLE; } sd->last_balance = jiffies; } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/