Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S272680AbSISUrB>; Thu, 19 Sep 2002 16:47:01 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S272948AbSISUrB>; Thu, 19 Sep 2002 16:47:01 -0400
Received: from dsl-65-188-251-69.telocity.com ([65.188.251.69]:3488 "EHLO
	orr.homenet") by vger.kernel.org with ESMTP id <S272680AbSISUrA>;
	Thu, 19 Sep 2002 16:47:00 -0400
Date: Thu, 19 Sep 2002 16:51:34 -0400
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: netdev@oss.sgi.com,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Donald Becker <becker@scyld.com>,
       Richard Gooch <rgooch@ras.ucalgary.ca>,
       "Patrick R. McManus" <mcmanus@ducksong.com>, edward_peng@dlink.com.tw
Subject: PATCH: sundance #4a
Message-ID: <20020919205134.GA17492@orr.falooley.org>
References: <Pine.LNX.4.44.0209190903050.29420-100000@beohost.scyld.com> <3D8A25D1.3060300@mandrakesoft.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="LZvS9be/3tNcYl/X"
Content-Disposition: inline
In-Reply-To: <3D8A25D1.3060300@mandrakesoft.com>
User-Agent: Mutt/1.4i
From: Jason Lunz <lunz@falooley.org>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 934
Lines: 32


--LZvS9be/3tNcYl/X
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


If you're going to bail when reading the ASIC fails, you need to
unregister the dev before you return or Bad Things happen.

Jason

--LZvS9be/3tNcYl/X
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=sundance-4a

--- sundance-garzik.c	Thu Sep 19 16:45:57 2002
+++ sundance-unreg.c	Thu Sep 19 16:48:22 2002
@@ -599,6 +599,7 @@
 		if (phy_idx == 0) {
 			printk(KERN_INFO "%s: No MII transceiver found, aborting.  ASIC status %x\n",
 				   dev->name, readl(ioaddr + ASICCtrl));
+			unregister_netdev(dev);
 			goto err_out_unmap_rx;
 		}
 

--LZvS9be/3tNcYl/X--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/