Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934260Ab3CZIgt (ORCPT ); Tue, 26 Mar 2013 04:36:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25110 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934247Ab3CZIgr (ORCPT ); Tue, 26 Mar 2013 04:36:47 -0400 Date: Tue, 26 Mar 2013 09:36:26 +0100 From: Anton Arapov To: Oleg Nesterov Cc: Srikar Dronamraju , LKML , Josh Stone , Frank Eigler , Peter Zijlstra , Ingo Molnar , Ananth N Mavinakayanahalli , adrian.m.negreanu@intel.com, Torsten.Polle@gmx.de Subject: Re: [PATCH 5/7] uretprobes: return probe exit, invoke handlers Message-ID: <20130326083626.GA22603@bandura.brq.redhat.com> References: <1363957745-6657-1-git-send-email-anton@redhat.com> <1363957745-6657-6-git-send-email-anton@redhat.com> <20130324162817.GD17037@redhat.com> <20130325154940.GA2178@bandura.brq.redhat.com> <20130325163800.GA8324@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130325163800.GA8324@redhat.com> X-PGP-Key: http://people.redhat.com/aarapov/gpg User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 51 On Mon, Mar 25, 2013 at 05:38:00PM +0100, Oleg Nesterov wrote: > On 03/25, Anton Arapov wrote: > > > > On Sun, Mar 24, 2013 at 05:28:17PM +0100, Oleg Nesterov wrote: > > > > > > Ignoring the fact you need put_uprobe/kfree, it seems that we should > > > do something like this, > > > > > > do { > > > handler_uretprobe_chain(...); > > > > > > if (!ri->dirty) // not chained > > > break; > > > > > > ri = ri->next; > > > } while (ri); > > > > > > utask->return_instances = ri; > > > No? > > > > Oleg, Do you mean > > > > do { > > handler_uretprobe_chain(...); > > > > ri = ri->next; > > > > if (!ri->dirty) // not chained > > break; > > } while (ri); > > > > utask->return_instances = ri; > > > > otherwise we stuck with the first instance in stack. > > Not sure I understand... but it is very possible I missed something. > > But the pseudo code I wrote is not correct, I meant > > utask->return_instances = ri->next; > > after the main loop. This all makes sense now. Thanks. Anton. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/