Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934322Ab3CZJXQ (ORCPT ); Tue, 26 Mar 2013 05:23:16 -0400 Received: from sauhun.de ([89.238.76.85]:57788 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934019Ab3CZJXO (ORCPT ); Tue, 26 Mar 2013 05:23:14 -0400 Date: Tue, 26 Mar 2013 10:23:07 +0100 From: Wolfram Sang To: Yuvaraj CD Cc: Naveen Krishna Chatradhi , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, w.sang@pengutronix.de, khali@linux-fr.org, ben-linux@fluff.org, grant.likely@secretlab.ca, devicetree-discuss@lists.ozlabs.org, sjg@chromium.org, grundler@chromium.org, naveenkrishna.ch@gmail.com, broonie@opensource.wolfsonmicro.com Subject: Re: [RFC: PATCH v5] i2c: exynos5: add High Speed I2C controller driver Message-ID: <20130326092306.GA8553@the-dreams.de> References: <1363062732-27869-1-git-send-email-ch.naveen@samsung.com> <1363796690-30242-1-git-send-email-ch.naveen@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 735 Lines: 17 > > + /* CLK_DIV max is 256 */ > > + for (i = 0; i < 256; i++) { > > + utemp1 = utemp0 / (i + 1); > > + /* SCLK_L/H max is 256 / 2 */ > > + if (utemp1 < 128) { > I think TSCLK_L and TSCLK_H both can be configured upto 255.Why > limiting it to < 128 ? > By limiting it to < 128 dont we achieve lesser SCL clock? Thanks for reviewing but please quote only the relevant part of the message (like I did). This improves readability a lot. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/