Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759531Ab3CZKVk (ORCPT ); Tue, 26 Mar 2013 06:21:40 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:55386 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742Ab3CZKVi (ORCPT ); Tue, 26 Mar 2013 06:21:38 -0400 Date: Tue, 26 Mar 2013 12:21:00 +0200 From: Felipe Balbi To: Graeme Gregory CC: Kishon Vijay Abraham I , Laxman Dewangan , "balbi@ti.com" , Rajendra Nayak , "grant.likely@secretlab.ca" , "rob.herring@calxeda.com" , "rob@landley.net" , "gregkh@linuxfoundation.org" , "s-guiriec@ti.com" , "sameo@linux.intel.com" , "broonie@opensource.wolfsonmicro.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver Message-ID: <20130326102100.GD11244@arwen.pp.htv.fi> Reply-To: References: <1362662506-14823-4-git-send-email-kishon@ti.com> <1364203926-24488-1-git-send-email-kishon@ti.com> <51501CFB.4020905@nvidia.com> <51513A40.7080905@ti.com> <515163F6.3010400@slimlogic.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YkJPYEFdoxh/AXLE" Content-Disposition: inline In-Reply-To: <515163F6.3010400@slimlogic.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3600 Lines: 98 --YkJPYEFdoxh/AXLE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Mar 26, 2013 at 09:01:42AM +0000, Graeme Gregory wrote: > >>> From: Graeme Gregory > >>> > >>> This is the driver for the OTG transceiver built into the Palmas > >>> chip. It > >>> handles the various USB OTG events that can be generated by cable > >>> insertion/removal. > >>> > >>> Signed-off-by: Graeme Gregory > >>> Signed-off-by: Moiz Sonasath > >>> Signed-off-by: Ruchika Kharwar > >>> Signed-off-by: Kishon Vijay Abraham I > >>> Signed-off-by: Sebastien Guiriec > >>> --- > >> > >> I think this driver is more over the cable connection like vbus > >> detetcion or ID pin detection. > >> Then why not it is implemented based on extcon framework? > > > > extcon framework uses notification mechanism and Felipe dint like > > using notification here. right Felipe? > >> > >> That way, generic usb driver (like tegra_usb driver) will get > >> notification through extcon. > >> > >> We need this cable detection through extcon on our tegra solution > >> through the Palmas. > >> > >> > >> +#include > >> +#include > >> + > >> +static int palmas_usb_read(struct palmas *palmas, unsigned int reg, > >> + unsigned int *dest) > >> +{ > >> + unsigned int addr; > >> + int slave; > >> + > >> + slave =3D PALMAS_BASE_TO_SLAVE(PALMAS_USB_OTG_BASE); > >> + addr =3D PALMAS_BASE_TO_REG(PALMAS_USB_OTG_BASE, reg); > >> + > >> + return regmap_read(palmas->regmap[slave], addr, dest); > >> > >> > >> Please use the generic api for palmas_read()/palmas_write(0 as it will > >> be ease on debugging on register access. > >> Direct regmap_read() does not help much on this. > > > > Graeme, > > Any reason why you dint use palmas_read()/palmas_write here? > > Btw palmas_read()/palmas_write() internally uses regmap APIs. > Because I was not a fan of tightly coupling the child devices to the > parent MFD. palmas_read/write were added by Laxman. I guess regmap would also help abstracting SPI versus I2C connection. IMHO, palmas_read/write should be removed. Laxman's complaint that it doesn't help with debugging is utter nonsense. --=20 balbi --YkJPYEFdoxh/AXLE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJRUXaMAAoJEIaOsuA1yqREGbIQAKh44ikYw974wNPdoFdpKD5i EZPwXO2eLbarQf35OHJo2eYpT3x4gngzZmAa00CPIu1ktdETgvMkm2shLAc8Tr7w fZzjXh140iursfslDsd8R0X/q2o656py/XzMF360Anl/ysbJ8b4wMDAXZD6Rzaev kMtr0ki63ZZ3oJrvnZN1eT0hkIWNO4gYIbSKgYNj2vN8EmGoZ5OZHLlPtk1ljoln ueoVRUOvjvw1ix0XokgTBRB84OjVwPUwNqzrjpB0CSjrbLzP0w9Q/FvfpJiePi/t iKUCLjLeyp156m5ckKE9rFdtSY+U4OT8pmIwcp2F2y/VRqaJM0wyO6j05jwRShJn HCW2slDVIn8xfFk8ZT6orWtnPdWoPLBEOzAD/FSguX5iWaFcEV7bZXaXezBmmH5R lbpJmNINidpdkURVL7cISnw/RPBBdZhvIlPhXki1c1dcYpfHKDSYDcJL11vqhhmC 3vzi2GptGCwhKbY5ovA2UrTub597X6fxVHzaZVjfX0uK/irOPCNTXNf3i9fV3fX3 Gh5xUu0HF+WNZVyAecK2FsPueTQ3nFI1opUlgHuLmPLL73SnwUp0fBCidVTqWNm/ MI+07tut23VpLaJgd7oXAuYt6QkFYNKhf3OUXLZHojNsdlubb8FZPEAyDGKptX3D V85fpMFUmzH/C1T+m24w =ifFf -----END PGP SIGNATURE----- --YkJPYEFdoxh/AXLE-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/