Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934191Ab3CZNRv (ORCPT ); Tue, 26 Mar 2013 09:17:51 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:43010 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933294Ab3CZNRt (ORCPT ); Tue, 26 Mar 2013 09:17:49 -0400 From: "Rafael J. Wysocki" To: Andrei Epure Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acpi: replaced kmalloc+memcpy with kmemdup Date: Tue, 26 Mar 2013 14:25:15 +0100 Message-ID: <3996362.Dl8iZzsvl7@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.9.0-rc4+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <1362990016-21249-1-git-send-email-epure.andrei@gmail.com> References: <1362990016-21249-1-git-send-email-epure.andrei@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 42 On Monday, March 11, 2013 10:20:16 AM Andrei Epure wrote: > Signed-off-by: Andrei Epure Added a changelog and applied to linux-pm.git/linux-next. Thanks, Rafael > --- > drivers/acpi/bus.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index 01708a1..292de3c 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -288,13 +288,12 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context) > } > out_success: > context->ret.length = out_obj->buffer.length; > - context->ret.pointer = kmalloc(context->ret.length, GFP_KERNEL); > + context->ret.pointer = kmemdup(out_obj->buffer.pointer, > + context->ret.length, GFP_KERNEL); > if (!context->ret.pointer) { > status = AE_NO_MEMORY; > goto out_kfree; > } > - memcpy(context->ret.pointer, out_obj->buffer.pointer, > - context->ret.length); > status = AE_OK; > > out_kfree: > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/