Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965202Ab3CZPqw (ORCPT ); Tue, 26 Mar 2013 11:46:52 -0400 Received: from mail.active-venture.com ([67.228.131.205]:63134 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965146Ab3CZPXB (ORCPT ); Tue, 26 Mar 2013 11:23:01 -0400 X-Originating-IP: 108.223.40.66 Date: Tue, 26 Mar 2013 08:23:10 -0700 From: Guenter Roeck To: Hongbo Zhang Cc: khali@linux-fr.org, lm-sensors@lm-sensors.org, cbou@mail.ru, dwmw2@infradead.org, linaro-kernel@lists.linaro.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@linaro.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver Message-ID: <20130326152310.GA9153@roeck-us.net> References: <1364281619-13208-1-git-send-email-hongbo.zhang@linaro.org> <1364281619-13208-6-git-send-email-hongbo.zhang@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1364281619-13208-6-git-send-email-hongbo.zhang@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1213 Lines: 31 On Tue, Mar 26, 2013 at 03:06:59PM +0800, Hongbo Zhang wrote: > Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500 > chips. This is ABX500 hwmon driver, where the abx500.c is a common layer for > all ABX500s, and the ab8500.c is specific for AB8500 chip. Under this designed > structure, other chip specific files can be added simply using the same common > layer abx500.c. > > Signed-off-by: Hongbo Zhang Looks good except ... > diff --git a/drivers/power/ab8500_bmdata.c b/drivers/power/ab8500_bmdata.c > index d9f1f25..05a1077 100644 > --- a/drivers/power/ab8500_bmdata.c > +++ b/drivers/power/ab8500_bmdata.c > @@ -28,8 +28,10 @@ const struct abx500_res_to_temp ab8500_temp_tbl_a_thermistor[] = { > {60, 13437}, > {65, 12500}, > }; > +EXPORT_SYMBOL(ab8500_temp_tbl_a_thermistor); > Those exports should be in the previous patch where you start exporting the symbols, not in this patch. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/