Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965709Ab3CZQgL (ORCPT ); Tue, 26 Mar 2013 12:36:11 -0400 Received: from exprod5og111.obsmtp.com ([64.18.0.22]:50249 "EHLO exprod5og111.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965531Ab3CZQgJ (ORCPT ); Tue, 26 Mar 2013 12:36:09 -0400 Message-ID: <5151CE72.5090800@ge.com> Date: Tue, 26 Mar 2013 16:36:02 +0000 From: Martyn Welch User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Kumar Amit Mehta CC: manohar.vanga@gmail.com, gregkh@linuxfoundation.org, yamanetoshi@gmail.com, joe@perches.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] staging: vme: fix for a potential NULL pointer dereference References: <1364189869-9275-1-git-send-email-gmate.amit@gmail.com> In-Reply-To: <1364189869-9275-1-git-send-email-gmate.amit@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1494 Lines: 42 On 25/03/13 05:37, Kumar Amit Mehta wrote: > Audit the return value of cdev_alloc and hence fixes a potential NULL pointer > dereferencing. > > Signed-off-by: Kumar Amit Mehta Looks good to me, thanks. Signed-off-by: Martyn Welch > --- > drivers/staging/vme/devices/vme_user.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c > index d074b1e..da7f759 100644 > --- a/drivers/staging/vme/devices/vme_user.c > +++ b/drivers/staging/vme/devices/vme_user.c > @@ -710,6 +710,10 @@ static int vme_user_probe(struct vme_dev *vdev) > > /* Register the driver as a char device */ > vme_user_cdev = cdev_alloc(); > + if (!vme_user_cdev) { > + err = -ENOMEM; > + goto err_char; > + } > vme_user_cdev->ops = &vme_user_fops; > vme_user_cdev->owner = THIS_MODULE; > err = cdev_add(vme_user_cdev, MKDEV(VME_MAJOR, 0), VME_DEVS); > -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.welch@ge.com | VAT:GB 927559189 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/