From: Arnd Bergmann <arnd@arndb.de>
To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [RFC PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol
Date: Tue, 26 Mar 2013 18:10:43 +0000
User-Agent: KMail/1.12.2 (Linux/3.8.0-13-generic; KDE/4.3.2; x86_64; ; )
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
References: <1364321177-12146-1-git-send-email-florian@openwrt.org> <1364321177-12146-3-git-send-email-florian@openwrt.org>
In-Reply-To: <1364321177-12146-3-git-send-email-florian@openwrt.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201303261810.44154.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1786
Lines: 44

On Tuesday 26 March 2013, Florian Fainelli wrote:
> 
> Just like the OHCI counter part we just can remove the architecture
> specific symbols which prevent these configuration symbols from being
> selected by platforms/architectures requiring it. The original
> implementation did not scale at all since it required each and every
> single architecture to be added for these configuration symbols to be
> selected. Now it is up to the EHCI driver and/or platform to select
> these configuration symbols accordingly.
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>

Good idea, just one suggestion:

>  config USB_EHCI_BIG_ENDIAN_MMIO
>         bool
> -       depends on USB_EHCI_HCD && (PPC_CELLEB || PPC_PS3 || 440EPX || \
> -                                   ARCH_IXP4XX || XPS_USB_HCD_XILINX || \
> -                                   PPC_MPC512x || CPU_CAVIUM_OCTEON || \
> -                                   PMC_MSP || SPARC_LEON || MIPS_SEAD3)
> -       default y
> +       depends on USB_EHCI_HCD
> +       default n
>  
>  config USB_EHCI_BIG_ENDIAN_DESC
>         bool
> -       depends on USB_EHCI_HCD && (440EPX || ARCH_IXP4XX || XPS_USB_HCD_XILINX || \
> -                                   PPC_MPC512x || PMC_MSP || SPARC_LEON || \
> -                                   MIPS_SEAD3)
> -       default y
> +       depends on USB_EHCI_HCD
> +       default n
>  
>  config XPS_USB_HCD_XILINX
>         bool "Use Xilinx usb host EHCI controller core"

You can drop the "default n" line as well, it's the default.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/