From: KY Srinivasan <kys@microsoft.com>
To: Olaf Hering <olaf@aepfle.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/3] Tools: hv: fix warnings in hv_vss_daemon
Thread-Topic: [PATCH 1/3] Tools: hv: fix warnings in hv_vss_daemon
Thread-Index: AQHOKja3d+L5xLojvEOFQMScGCXgxJi4T2qg
Date: Tue, 26 Mar 2013 18:44:45 +0000
Message-ID: <9c53a9e4e0b04d89a9d9bbc28a8258b4@SN2PR03MB061.namprd03.prod.outlook.com>
References: <1364311709-18228-1-git-send-email-olaf@aepfle.de>
In-Reply-To: <1364311709-18228-1-git-send-email-olaf@aepfle.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2356
Lines: 78


> -----Original Message-----
> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Tuesday, March 26, 2013 11:28 AM
> To: KY Srinivasan; gregkh@linuxfoundation.org
> Cc: linux-kernel@vger.kernel.org; Olaf Hering
> Subject: [PATCH 1/3] Tools: hv: fix warnings in hv_vss_daemon
> 
> This change fixes a few compile errors:
> 
> hv_vss_daemon.c:64:15: warning: unknown escape sequence '\/'
> hv_vss_daemon.c:64:15: warning: unknown escape sequence '\/'
> hv_vss_daemon.c: In function 'vss_operate':
> hv_vss_daemon.c:66: warning: 'return' with no value, in function returning non-
> void
> hv_vss_daemon.c: In function 'main':
> hv_vss_daemon.c:130: warning: ignoring return value of 'daemon', declared with
> attribute warn_unused_result
> hv_vss_daemon.c: In function 'vss_operate':
> hv_vss_daemon.c:47: warning: 'fs_op' may be used uninitialized in this function
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Thanks for fixing this.

Acked by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  tools/hv/hv_vss_daemon.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
> index 9526995..2a03d0b 100644
> --- a/tools/hv/hv_vss_daemon.c
> +++ b/tools/hv/hv_vss_daemon.c
> @@ -51,7 +51,7 @@ static int vss_operate(int operation)
>  	FILE *file;
>  	char *p;
>  	char *x;
> -	int error;
> +	int error = 0;
> 
>  	switch (operation) {
>  	case VSS_OP_FREEZE:
> @@ -60,11 +60,13 @@ static int vss_operate(int operation)
>  	case VSS_OP_THAW:
>  		fs_op = "-u ";
>  		break;
> +	default:
> +		return -1;
>  	}
> 
> -	file = popen("mount | awk '/^\/dev\// { print $3}'", "r");
> +	file = popen("mount | awk '/^\\/dev\\// { print $3}'", "r");
>  	if (file == NULL)
> -		return;
> +		return -1;
> 
>  	while ((p = fgets(buf, sizeof(buf), file)) != NULL) {
>  		x = strchr(p, '\n');
> @@ -128,7 +130,9 @@ int main(void)
>  	int	op;
>  	struct hv_vss_msg *vss_msg;
> 
> -	daemon(1, 0);
> +	if (daemon(1, 0))
> +		return 1;
> +
>  	openlog("Hyper-V VSS", 0, LOG_USER);
>  	syslog(LOG_INFO, "VSS starting; pid is:%d", getpid());
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/