Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755896Ab3CZWv1 (ORCPT ); Tue, 26 Mar 2013 18:51:27 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:43814 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755871Ab3CZWvY (ORCPT ); Tue, 26 Mar 2013 18:51:24 -0400 From: "Rafael J. Wysocki" To: Bjorn Helgaas Cc: Yinghai Lu , Linus Torvalds , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] PCI, ACPI: hold acpi_scan_lock during root bus hotplug Date: Tue, 26 Mar 2013 23:58:50 +0100 Message-ID: <13791994.aJX11d8f7N@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.9.0-rc4+; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: <1673357.1IdxNNvGWX@vostro.rjw.lan> <2166148.RX0m5V0khX@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 41 On Tuesday, March 26, 2013 04:48:49 PM Bjorn Helgaas wrote: > On Tue, Mar 26, 2013 at 4:54 PM, Rafael J. Wysocki wrote: > > On Tuesday, March 26, 2013 08:12:30 AM Yinghai Lu wrote: > >> On Tue, Mar 26, 2013 at 6:24 AM, Rafael J. Wysocki wrote: > >> > On Sunday, March 10, 2013 10:05:16 PM Yinghai Lu wrote: > >> >> During merging pci tree with pm/acpi tree, Linus noticed that > >> >> we don't have same lock using patten about acpi pci root as > >> >> acpiphp. > >> >> > >> >> Here apply same lock patten, and we need to change > >> >> acpi_bus_hot_remove_device executing via acpi_os_hotplug_execute() > >> >> as it also hold the lock in acpi_bus_hot_remove_device. > >> >> > >> >> That will make acpi_bus_hot_remove_device calling the same as other > >> >> callers. > >> >> > >> >> Reported-by: Linus Torvalds > >> >> Signed-off-by: Yinghai Lu > >> >> Acked-by: Rafael J. Wysocki > >> > > >> > Bjorn, this needs to go in before final 3.9. > >> > > >> > Are you going to handle it, or should I take care of it? > >> > >> It should be better via your pm+acpi tree, as that lock is added via your tree. > > > > OK, I'll take it, then, if Bjorn doesn't object. > > Yep, that's fine with me. Cool, thanks. :-) -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/