Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757078Ab3CZXE0 (ORCPT ); Tue, 26 Mar 2013 19:04:26 -0400 Received: from 8bytes.org ([85.214.48.195]:46454 "EHLO mail.8bytes.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757069Ab3CZXEW (ORCPT ); Tue, 26 Mar 2013 19:04:22 -0400 Date: Wed, 27 Mar 2013 00:03:59 +0100 From: Joerg Roedel To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: zsmalloc: Fix link error on ARM Message-ID: <20130326230359.GD30540@8bytes.org> References: <1364337232-3513-1-git-send-email-joro@8bytes.org> <20130326224536.GA29952@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130326224536.GA29952@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Wed Mar 27 00:04:00 2013 X-DSPAM-Confidence: 0.9990 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 5152296023671496467140 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1138 Lines: 30 On Tue, Mar 26, 2013 at 03:45:36PM -0700, Greg Kroah-Hartman wrote: > On Tue, Mar 26, 2013 at 11:33:52PM +0100, Joerg Roedel wrote: > > Testing the arm chromebook config against the upstream > > kernel produces a linker error for the zsmalloc module from > > staging. The symbol flush_tlb_kernel_range is not available > > there. Fix this by removing the reimplementation of > > unmap_kernel_range in the zsmalloc module and using the > > function directly. > > > > Signed-off-by: Joerg Roedel > > Why is this not an error for any other architecture? Why is arm > special? The version of the function __zs_unmap_object() which uses flush_tlb_kernel_range() in the zsmalloc driver is only compiled in when USE_PGTABLE_MAPPING is defined. And USE_PGTABLE_MAPPING is defined in the same file only when CONFIG_ARM is defined. So this happens only on ARM. Regards, Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/