Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756589Ab3CZXJQ (ORCPT ); Tue, 26 Mar 2013 19:09:16 -0400 Received: from mail-da0-f53.google.com ([209.85.210.53]:37785 "EHLO mail-da0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755351Ab3CZXJM (ORCPT ); Tue, 26 Mar 2013 19:09:12 -0400 Date: Tue, 26 Mar 2013 16:09:10 -0700 From: Greg Kroah-Hartman To: Joerg Roedel Cc: devel@driverdev.osuosl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: zsmalloc: Fix link error on ARM Message-ID: <20130326230910.GA31021@kroah.com> References: <1364337232-3513-1-git-send-email-joro@8bytes.org> <20130326224536.GA29952@kroah.com> <20130326230359.GD30540@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130326230359.GD30540@8bytes.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 32 On Wed, Mar 27, 2013 at 12:03:59AM +0100, Joerg Roedel wrote: > On Tue, Mar 26, 2013 at 03:45:36PM -0700, Greg Kroah-Hartman wrote: > > On Tue, Mar 26, 2013 at 11:33:52PM +0100, Joerg Roedel wrote: > > > Testing the arm chromebook config against the upstream > > > kernel produces a linker error for the zsmalloc module from > > > staging. The symbol flush_tlb_kernel_range is not available > > > there. Fix this by removing the reimplementation of > > > unmap_kernel_range in the zsmalloc module and using the > > > function directly. > > > > > > Signed-off-by: Joerg Roedel > > > > Why is this not an error for any other architecture? Why is arm > > special? > > The version of the function __zs_unmap_object() which uses > flush_tlb_kernel_range() in the zsmalloc driver is only compiled in when > USE_PGTABLE_MAPPING is defined. And USE_PGTABLE_MAPPING is defined in > the same file only when CONFIG_ARM is defined. So this happens only on > ARM. Then should I just mark the driver as broken on ARM? Any reason for not including the driver authors on the Cc: for this patch? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/