Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756178Ab3C0ILo (ORCPT ); Wed, 27 Mar 2013 04:11:44 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:51045 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789Ab3C0ILm (ORCPT ); Wed, 27 Mar 2013 04:11:42 -0400 MIME-Version: 1.0 In-Reply-To: <20130305212238.5bf8d974@endymion.delvare> References: <20130305212238.5bf8d974@endymion.delvare> Date: Wed, 27 Mar 2013 09:11:41 +0100 Message-ID: Subject: Re: [PATCH 1/2 v2] gpio-ich: Check for pin availability at request time From: Linus Walleij To: Jean Delvare Cc: Peter Tyser , LKML , Grant Likely Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 24 On Tue, Mar 5, 2013 at 9:22 PM, Jean Delvare wrote: > Stop checking for pin availability in direction and get functions. > These functions can be called repeatedly, so checking every time is > bad for performance. Now that requesting GPIO pins is no longer > optional, checking for availability at pin request time is enough. > > Signed-off-by: Jean Delvare > Cc: Peter Tyser > Cc: Grant Likely > Cc: Linus Walleij > --- > Changes since v1: > * Also drop the check from direction functions, as suggested by Peter. Patch applied. Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/