Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751753Ab3C0POw (ORCPT ); Wed, 27 Mar 2013 11:14:52 -0400 Received: from anubis.se.axis.com ([195.60.68.12]:45902 "EHLO anubis.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073Ab3C0POu (ORCPT ); Wed, 27 Mar 2013 11:14:50 -0400 X-Greylist: delayed 622 seconds by postgrey-1.27 at vger.kernel.org; Wed, 27 Mar 2013 11:14:50 EDT Date: Wed, 27 Mar 2013 16:04:24 +0100 From: Jesper Nilsson To: Thomas Gleixner Cc: LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , Rusty Russell , Paul McKenney , Ingo Molnar , Peter Zijlstra , "Srivatsa S. Bhat" , Magnus Damm Subject: Re: [patch 13/34] cris: Use generic idle loop Message-ID: <20130327150421.GV28422@axis.com> References: <20130321214930.752934102@linutronix.de> <20130321215234.148829489@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130321215234.148829489@linutronix.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 40 On Thu, Mar 21, 2013 at 09:53:06PM -0000, Thomas Gleixner wrote: [snip] > Index: linux-2.6/arch/cris/arch-v32/kernel/process.c > =================================================================== > --- linux-2.6.orig/arch/cris/arch-v32/kernel/process.c > +++ linux-2.6/arch/cris/arch-v32/kernel/process.c > @@ -23,12 +23,10 @@ extern void stop_watchdog(void); > /* We use this if we don't have any better idle routine. */ > void default_idle(void) > { > - local_irq_disable(); > - if (!need_resched()) { > - /* Halt until exception. */ > - __asm__ volatile("ei \n\t" > - "halt "); > - } > + /* Halt until exception. */ > + __asm__ volatile("ei \n\t" > + "halt "); > + /* CHECKME: Is this really needed ?? */ > local_irq_enable(); No, that local_irq_enable() is redundant since we already enabled interrupts in the assembler directive above. > } Looks good, Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/