Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926Ab3C0QLE (ORCPT ); Wed, 27 Mar 2013 12:11:04 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58620 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837Ab3C0QLC (ORCPT ); Wed, 27 Mar 2013 12:11:02 -0400 From: Oliver Neukum To: Alex Williamson Cc: Michal Marek , Matthew Garrett , Takashi Iwai , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pciehp: Add pciehp_surprise module option Date: Wed, 27 Mar 2013 17:11:39 +0100 Message-ID: <5658592.BRAWLYK6e8@linux-5eaq.site> Organization: SUSE User-Agent: KMail/4.8.5 (Linux/3.8.0-rc7-12-desktop+; KDE/4.8.5; x86_64; ; ) In-Reply-To: <1363969243.24132.613.camel@bling.home> References: <514C8388.3050200@suse.cz> <1363969243.24132.613.camel@bling.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 21 On Friday 22 March 2013 10:20:43 Alex Williamson wrote: > > (*) It would probably make more sense to have a list of dmi strings, > > because it's the PCIe controller that does not set the capability bit > > when it should. The device (Realtek card reader in this case) seems to > > behave correctly. The machines in question have been laptops or > > all-in-one PCs so far, so there should be no problem with dmi matches. > > Yep, I think that makes sense, leave the global option for debugging but > fix individual known broken devices through dmi quirks. Thanks, I checked with Win8 and it does ignore the surprise attribute. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/