Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752531Ab3C0QyM (ORCPT ); Wed, 27 Mar 2013 12:54:12 -0400 Received: from mail-vb0-f41.google.com ([209.85.212.41]:64888 "EHLO mail-vb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536Ab3C0QyK (ORCPT ); Wed, 27 Mar 2013 12:54:10 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130310221047.GA21522@ZenIV.linux.org.uk> <20130311003530.GE21522@ZenIV.linux.org.uk> <20130311180543.GF21522@ZenIV.linux.org.uk> <20130312130614.GA32237@ZenIV.linux.org.uk> <20130312194353.GI21522@ZenIV.linux.org.uk> <20130327135127.GB1738@redhat.com> <20130327152030.GY21522@ZenIV.linux.org.uk> From: Raymond Jennings Date: Wed, 27 Mar 2013 09:53:29 -0700 Message-ID: Subject: Re: Yet another pipe related oops. To: Linus Torvalds Cc: Al Viro , Dave Jones , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1648 Lines: 42 On Wed, Mar 27, 2013 at 9:33 AM, Linus Torvalds wrote: > On Wed, Mar 27, 2013 at 8:20 AM, Al Viro wrote: >> >> Actually, that's my fault - check lost in patch reordering. My apologies ;-/ >> Eventually, we want that in fs/splice.c side of things (no point repeating it >> for every buffer, after all), but for now this is the obvious minimal fix. > > Applied. > > Do we actually have files with NULL f_ops pointers? Should we? What > could we possibly do with a file descriptor that doesn't have any > fops? For the sake of the curious including myself: How would such a NULL f_ops file get created in the first place? > Also, perhaps we should do something more akin to what we do for > dentry functions where we validate them on registration, and we could > fix up or validate read/write pointers, with semantics something like > > if (!fop->write) > fop->write = fop->aio_write ? do_sync_write : EINVAL_write; > if (!fop->read) > fop->read = fop->aio_read ? do_sync_read : EINVAL_read; > > kind of things? > > Not a big deal, perhaps. > > Linus > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/