MIME-Version: 1.0
In-Reply-To: <87a9ppgvbk.fsf@sejong.aot.lge.com>
References: <CA+BNSkWCX2TVYU26A7qHFqr6F5Pw44wy76BSfnS5MnVDKGCh9w@mail.gmail.com>
	<87a9ppgvbk.fsf@sejong.aot.lge.com>
Date: Wed, 27 Mar 2013 10:07:52 -0700
Message-ID: <CA+BNSkVVmnUJuas2DFOoF6OBfZpnK16S9u2pvawv+aELgNUBHw@mail.gmail.com>
Subject: Re: [PATCH v2] perf: add callgrind conversion tool
From: Roberto Vitillo <ravitillo@lbl.gov>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, paulus@samba.org,
        mingo@redhat.com, acme@ghostprotocols.net
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1205
Lines: 32

On Wed, Mar 27, 2013 at 12:23 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> Hi Roberto,
>
> On Tue, 26 Mar 2013 12:14:49 -0700, Roberto Vitillo wrote:
>> The proposed patch adds the convert tool to perf which allows to convert a
>> perf.data file to a set of callgrind data files which can subsequently be
>> displayed with kcachegrind.
>>
>> Note that the code may trigger the following bug in libbfd:
>> http://sourceware.org/bugzilla/show_bug.cgi?id=15106
>
> Does it now support call graph too?  Great if so!

Yes it does.

> Anyway, I suggest that splitting patch to two - one for addr2line and
> another for actual 'convert' tool.

Ok

> I think we *can* use the tool
> without libbfd (but with external addr2line binary or even with no line
> number information).

Well, I could use the external addr2line binary but the tool will
become terribly slow. A warning message could notify the
user to recompile perf with libbfd to speed up the conversion.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/