Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753417Ab3C0RJU (ORCPT ); Wed, 27 Mar 2013 13:09:20 -0400 Received: from www.linutronix.de ([62.245.132.108]:36683 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626Ab3C0RJT (ORCPT ); Wed, 27 Mar 2013 13:09:19 -0400 Date: Wed, 27 Mar 2013 18:09:16 +0100 (CET) From: Thomas Gleixner To: Mike Turquette cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, patches@linaro.org, Laurent Pinchart , David Brown , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4] clk: allow reentrant calls into the clk framework In-Reply-To: <20130327164716.4014.97638@quantum> Message-ID: References: <1364368183-24420-1-git-send-email-mturquette@linaro.org> <20130327164716.4014.97638@quantum> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 576 Lines: 19 On Wed, 27 Mar 2013, Mike Turquette wrote: > Thanks for the review Thomas. I will steal your code and call it my own > in the next version. Sure. > In particular getting rid of the atomics makes things much nicer. I'd say using the helper functions and not having all these conditionals makes it really nice :) Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/