Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753332Ab3C0R2E (ORCPT ); Wed, 27 Mar 2013 13:28:04 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:59064 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752651Ab3C0R2B (ORCPT ); Wed, 27 Mar 2013 13:28:01 -0400 MIME-Version: 1.0 In-Reply-To: <1363665251-14377-1-git-send-email-linfeng@cn.fujitsu.com> References: <1363665251-14377-1-git-send-email-linfeng@cn.fujitsu.com> From: Bjorn Helgaas Date: Wed, 27 Mar 2013 11:27:41 -0600 Message-ID: Subject: Re: [PATCH] kernel/range.c: subtract_range: fix the broken phrase issued by printk To: Lin Feng Cc: Andrew Morton , linux-mm@kvack.org, "x86@kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yinghai Lu Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1650 Lines: 39 On Mon, Mar 18, 2013 at 9:54 PM, Lin Feng wrote: > Also replace deprecated printk(KERN_ERR...) with pr_err() as suggested > by Yinghai, attaching the function name to provide plenty info. > > Cc: Yinghai Lu > Signed-off-by: Lin Feng > --- > kernel/range.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/range.c b/kernel/range.c > index 9b8ae2d..071b0ab 100644 > --- a/kernel/range.c > +++ b/kernel/range.c > @@ -97,7 +97,8 @@ void subtract_range(struct range *range, int az, u64 start, u64 end) > range[i].end = range[j].end; > range[i].start = end; > } else { > - printk(KERN_ERR "run of slot in ranges\n"); > + pr_err("%s: run out of slot in ranges\n", > + __func__); > } > range[j].end = start; > continue; So now the user might see: subtract_range: run out of slot in ranges What is the user supposed to do when he sees that? If he happens to mention it on LKML, what are we going to do about it? If he attaches the complete dmesg log, is there enough information to do something? IMHO, that message is still totally useless. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/