Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 20 Sep 2002 04:22:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 20 Sep 2002 04:22:16 -0400 Received: from angband.namesys.com ([212.16.7.85]:53915 "HELO angband.namesys.com") by vger.kernel.org with SMTP id ; Fri, 20 Sep 2002 04:22:15 -0400 Date: Fri, 20 Sep 2002 12:27:16 +0400 From: Oleg Drokin To: Ingo Molnar Cc: Linus Torvalds , William Lee Irwin III , linux-kernel@vger.kernel.org Subject: Re: [patch] generic-pidhash-2.5.36-D4, BK-curr Message-ID: <20020920122716.A2297@namesys.com> References:

Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.22.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 798 Lines: 25 Hello! On Thu, Sep 19, 2002 at 04:54:46AM +0200, Ingo Molnar wrote: > - unified kernel/pid.c and kernel/idtag.c into kernel/pid.c. > + /* > + * Free the page if someone raced with us > + * installing it: > + */ > + if (cmpxchg(&map->page, NULL, page)) > + free_page(page); Note that this piece breaks compilation for every arch that does not have cmpxchg implementation. This is the case with x86 (with CONFIG_X86_CMPXCHG undefined, e.g. i386), ARM, CRIS, m68k, MIPS, MIPS64, PARISC, s390, SH, sparc32, UML (for x86). Bye, Oleg - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/