Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753779Ab3C0Siv (ORCPT ); Wed, 27 Mar 2013 14:38:51 -0400 Received: from smtp-out-081.synserver.de ([212.40.185.81]:1288 "EHLO smtp-out-226.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753513Ab3C0Sis (ORCPT ); Wed, 27 Mar 2013 14:38:48 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 7311 Message-ID: <51533D34.7020406@metafoo.de> Date: Wed, 27 Mar 2013 19:40:52 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Naveen Krishna Ch CC: Doug Anderson , Jonathan Cameron , Kukjin Kim , Naveen Krishna Chatradhi , Olof Johansson , Guenter Roeck , Grant Likely , Rob Herring , Rob Landley , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] iio: adc: Document the regulator/clocks for exynos-adc References: <1363129994-10438-1-git-send-email-dianders@chromium.org> <1363207202-10858-1-git-send-email-dianders@chromium.org> <1363207202-10858-2-git-send-email-dianders@chromium.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2314 Lines: 64 On 03/27/2013 07:35 PM, Naveen Krishna Ch wrote: > On 13 March 2013 13:39, Doug Anderson wrote: >> The exynos ADC won't work without a regulator called "vdd" and a clock >> called "adc". Document this fact in the device tree bindings. >> >> Signed-off-by: Doug Anderson > Reviewed-by: Naveen Krishna Chatradhi > > Lars, any update on this patch set. This change is required. Uhm, looks fine to me. I'm sure Jonathan will pick it up :) >> --- >> Changes in v2: None >> >> Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt >> index f686378..96db940 100644 >> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt >> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt >> @@ -20,6 +20,9 @@ Required properties: >> format is being dependent on which interrupt controller >> the Samsung device uses. >> - #io-channel-cells = <1>; As ADC has multiple outputs >> +- clocks From common clock binding: handle to adc clock. >> +- clock-names From common clock binding: Shall be "adc". >> +- vdd-supply VDD input supply. >> >> Note: child nodes can be added for auto probing from device tree. >> >> @@ -31,6 +34,11 @@ adc: adc@12D10000 { >> interrupts = <0 106 0>; >> #io-channel-cells = <1>; >> io-channel-ranges; >> + >> + clocks = <&clock 303>; >> + clock-names = "adc"; >> + >> + vdd-supply = <&buck5_reg>; >> }; >> >> >> -- >> 1.8.1.3 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > > > -- > Shine bright, > (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/