Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754513Ab3C0Tai (ORCPT ); Wed, 27 Mar 2013 15:30:38 -0400 Received: from casper.infradead.org ([85.118.1.10]:58898 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754385Ab3C0Taf (ORCPT ); Wed, 27 Mar 2013 15:30:35 -0400 Message-ID: <51533AD3.9040809@infradead.org> Date: Wed, 27 Mar 2013 11:30:43 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Mark Brown CC: Xiong Zhou , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell Subject: Re: [patch v2] sound/soc/codecs : fix build failure for next-20130325 References: <20130327133915.GU18316@opensource.wolfsonmicro.com> In-Reply-To: <20130327133915.GU18316@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 40 On 03/27/13 06:39, Mark Brown wrote: > On Wed, Mar 27, 2013 at 09:31:33PM +0800, Xiong Zhou wrote: > >> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig >> index 18fea10..f38af70 100644 >> --- a/sound/soc/codecs/Kconfig >> +++ b/sound/soc/codecs/Kconfig >> @@ -79,7 +79,6 @@ config SND_SOC_ALL_CODECS >> select SND_SOC_WM0010 if SPI_MASTER >> select SND_SOC_WM1250_EV1 if I2C >> select SND_SOC_WM2000 if I2C >> - select SND_SOC_WM2200 if I2C >> select SND_SOC_WM5100 if I2C >> select SND_SOC_WM5102 if MFD_WM5102 >> select SND_SOC_WM5110 if MFD_WM5110 >> @@ -370,6 +369,7 @@ config SND_SOC_WM2000 >> tristate >> >> config SND_SOC_WM2200 >> + depends on SND_SOC_ARIZONA && I2C >> tristate > > I really don't understand this at all, removing something from > ALL_CODECS is not a good idea. This isn't a Kconfig issue. > Hi Mark, Do you have a suggestion for a kernel config where SND_SOC_ARIZONA is not enabled but SND_SOC_WM_ADSP is enabled, which causes a build error in linux-next? thanks, -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/