From: Jingoo Han <jg1.han@samsung.com>
To: "'Wei Yongjun'" <weiyj.lk@gmail.com>,
        "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: "'Rafael J. Wysocki'" <rjw@sisk.pl>, "'Jens Axboe'" <axboe@kernel.dk>,
        yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org,
        "'Jingoo Han'" <jg1.han@samsung.com>
References: <CAPgLHd87a0=e8pX4YRwpxzxk1=YgcVimjxTFnpJKH8wRs1WfjQ@mail.gmail.com>
In-reply-to: <CAPgLHd87a0=e8pX4YRwpxzxk1=YgcVimjxTFnpJKH8wRs1WfjQ@mail.gmail.com>
Subject: Re: [PATCH -next] mg_disk: fix error return code in mg_probe()
Date: Thu, 28 Mar 2013 13:43:56 +0900
Message-id: <000501ce2b6e$db4963e0$91dc2ba0$%han@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: Ac4rbS+UQ91DapY3TJy4u50o6kiv9AAAKDeA
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1310
Lines: 43

On Thursday, March 28, 2013 1:32 PM, Wei Yongjun wrote:
> 
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

CC'ed Jens Axboe

It looks good.
Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  drivers/block/mg_disk.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c
> index 532bb89..a56cfcd 100644
> --- a/drivers/block/mg_disk.c
> +++ b/drivers/block/mg_disk.c
> @@ -892,8 +892,10 @@ static int mg_probe(struct platform_device *plat_dev)
>  	gpio_direction_output(host->rst, 1);
> 
>  	/* reset out pin */
> -	if (!(prv_data->dev_attr & MG_DEV_MASK))
> +	if (!(prv_data->dev_attr & MG_DEV_MASK)) {
> +		err = -EINVAL;
>  		goto probe_err_3a;
> +	}
> 
>  	if (prv_data->dev_attr != MG_BOOT_DEV) {
>  		rsc = platform_get_resource_byname(plat_dev, IORESOURCE_IO,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/