Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751510Ab3C1E70 (ORCPT ); Thu, 28 Mar 2013 00:59:26 -0400 Received: from server.prisktech.co.nz ([115.188.14.127]:53558 "EHLO server.prisktech.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064Ab3C1E7S (ORCPT ); Thu, 28 Mar 2013 00:59:18 -0400 Message-ID: <1364446785.15039.1.camel@gitbox> Subject: Re: [Bulk] [PATCH] video: fix invalid free of devm_ allocated data From: Tony Prisk To: Andrei Epure Cc: FlorianSchandinat@gmx.de, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 28 Mar 2013 17:59:45 +1300 In-Reply-To: <1364428524-13821-1-git-send-email-epure.andrei@gmail.com> References: <1364428524-13821-1-git-send-email-epure.andrei@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1970 Lines: 65 On Thu, 2013-03-28 at 01:55 +0200, Andrei Epure wrote: > The objects allocated by devm_* APIs are managed by devres and are freed when > the device is detached. Hence there is no need to use kfree() explicitly. > Patch found using coccinelle. > > Signed-off-by: Andrei Epure > --- > drivers/video/vt8500lcdfb.c | 3 --- > drivers/video/wm8505fb.c | 3 --- > 2 files changed, 6 deletions(-) > > diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c > index b4ccca2..ea3ee61 100644 > --- a/drivers/video/vt8500lcdfb.c > +++ b/drivers/video/vt8500lcdfb.c > @@ -465,7 +465,6 @@ failed_free_res: > release_mem_region(res->start, resource_size(res)); > failed_fbi: > platform_set_drvdata(pdev, NULL); > - kfree(fbi); > failed: > return ret; > } > @@ -494,8 +493,6 @@ static int vt8500lcd_remove(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > release_mem_region(res->start, resource_size(res)); > > - kfree(fbi); > - > return 0; > } > > diff --git a/drivers/video/wm8505fb.c b/drivers/video/wm8505fb.c > index 2e8298e..34a2de1 100644 > --- a/drivers/video/wm8505fb.c > +++ b/drivers/video/wm8505fb.c > @@ -427,7 +427,6 @@ failed_free_res: > release_mem_region(res->start, resource_size(res)); > failed_fbi: > platform_set_drvdata(pdev, NULL); > - kfree(fbi); > failed: > return ret; > } > @@ -451,8 +450,6 @@ static int wm8505fb_remove(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > release_mem_region(res->start, resource_size(res)); > > - kfree(fbi); > - > return 0; > } > NACK Already have a patch queued up for this from Julia Lawall Regards Tony P -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/