Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756431Ab3C1Hlo (ORCPT ); Thu, 28 Mar 2013 03:41:44 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:63063 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755696Ab3C1Hll (ORCPT ); Thu, 28 Mar 2013 03:41:41 -0400 MIME-Version: 1.0 In-Reply-To: References: <1363628226-6679-1-git-send-email-yinghai@kernel.org> Date: Thu, 28 Mar 2013 00:41:40 -0700 X-Google-Sender-Auth: 46jrIGvceX3ZutR6raquzsUnF_c Message-ID: Subject: Re: [PATCH] PCI: Remove not needed check in disable aspm link From: Yinghai Lu To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Taku Izumi , Kenji Kaneshige , stable@kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 22 On Wed, Mar 27, 2013 at 3:56 PM, Bjorn Helgaas wrote: > > Why can't we set all the ASPM flags *first*, before calling > pci_acpi_scan_root()? That way we could just do the correct ASPM > setup as we discover devices during enumeration, rather than trying to > fix things up afterwards. I suspect pcie_clear_aspm() is broken > anyway, because it looks like it only touches one level of the > hierarchy, without recursively descending it. Yes, we can clean up aspm stop/clear up. and that should be for 3.10 right? But this patch should be safe for 3.9 and stable. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/