Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756955Ab3C1Jw5 (ORCPT ); Thu, 28 Mar 2013 05:52:57 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:46870 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756442Ab3C1Jw4 (ORCPT ); Thu, 28 Mar 2013 05:52:56 -0400 Date: Thu, 28 Mar 2013 09:52:28 +0000 From: Russell King - ARM Linux To: Tony Lindgren Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Juha Yrjola , Matt Mackall , Herbert Xu , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] OMAP3 ROM Random Number Generator support Message-ID: <20130328095228.GT30923@n2100.arm.linux.org.uk> References: <201302281905.48546@pali> <20130327210918.GP10155@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130327210918.GP10155@atomide.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 502 Lines: 11 On Wed, Mar 27, 2013 at 02:09:18PM -0700, Tony Lindgren wrote: > > + setup_timer(&idle_timer, omap3_rom_idle_rng, 0); > > + rng_clk = clk_get_sys("omap_rng", "ick"); Why is this using clk_get_sys when it should be using clk_get() with the platform device? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/