Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755983Ab3C1MrE (ORCPT ); Thu, 28 Mar 2013 08:47:04 -0400 Received: from mail-ve0-f176.google.com ([209.85.128.176]:58393 "EHLO mail-ve0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755407Ab3C1Mq7 (ORCPT ); Thu, 28 Mar 2013 08:46:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <1363628226-6679-1-git-send-email-yinghai@kernel.org> From: Bjorn Helgaas Date: Thu, 28 Mar 2013 06:46:39 -0600 Message-ID: Subject: Re: [PATCH] PCI: Remove not needed check in disable aspm link To: Yinghai Lu Cc: "Rafael J. Wysocki" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Taku Izumi , Kenji Kaneshige , stable@kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 29 On Thu, Mar 28, 2013 at 1:41 AM, Yinghai Lu wrote: > On Wed, Mar 27, 2013 at 3:56 PM, Bjorn Helgaas wrote: >> >> Why can't we set all the ASPM flags *first*, before calling >> pci_acpi_scan_root()? That way we could just do the correct ASPM >> setup as we discover devices during enumeration, rather than trying to >> fix things up afterwards. I suspect pcie_clear_aspm() is broken >> anyway, because it looks like it only touches one level of the >> hierarchy, without recursively descending it. > > Yes, we can clean up aspm stop/clear up. > and that should be for 3.10 right? > > But this patch should be safe for 3.9 and stable. This patch might be *safe*, but it (and the changelog) are completely unintelligible. The problem with applying an unintelligible stop-gap patch is that it becomes forever part of the changelog, and it's a huge waste of time to everybody who tries to understand the history later. That's why I think it's worth spending some time to make a good patch now. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/