Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756244Ab3C1OEX (ORCPT ); Thu, 28 Mar 2013 10:04:23 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:37176 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756100Ab3C1OEW (ORCPT ); Thu, 28 Mar 2013 10:04:22 -0400 Date: Thu, 28 Mar 2013 10:04:06 -0400 From: Neil Horman To: Jeff Layton Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, tj@kernel.org, Vlad Yasevich , Sridhar Samudrala , "David S. Miller" , linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 6/6] sctp: convert sctp_assoc_set_id to use idr_alloc_cyclic Message-ID: <20130328140406.GB14489@neilslaptop.think-freely.org> References: <1364412578-7462-1-git-send-email-jlayton@redhat.com> <1364412578-7462-7-git-send-email-jlayton@redhat.com> <20130328135308.GA14489@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130328135308.GA14489@neilslaptop.think-freely.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 36 On Thu, Mar 28, 2013 at 09:53:08AM -0400, Neil Horman wrote: > On Wed, Mar 27, 2013 at 03:29:38PM -0400, Jeff Layton wrote: > > (Note: compile-tested only) > > > > Signed-off-by: Jeff Layton > > Cc: Vlad Yasevich > > Cc: Sridhar Samudrala > > Cc: Neil Horman > > Cc: "David S. Miller" > > Cc: linux-sctp@vger.kernel.org > > Cc: netdev@vger.kernel.org > > --- > > net/sctp/associola.c | 16 ++-------------- > > 1 file changed, 2 insertions(+), 14 deletions(-) > > > I don't see anything wrong with this patch per-se, but the idr_alloc_cyclic call > isn't integrated with net/net-next or Linus' tree yet. If we don't gate this > patch on that integration, we'll break the build. > Neil > Actually, I just noticed that you only sent us 6/6 here, I'm assuming a prior patch in the series adds the idr_alloc_cyclic code? if so, I've seen the prior version Acked-by: Neil Horman > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/