Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757250Ab3C1QPO (ORCPT ); Thu, 28 Mar 2013 12:15:14 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:57422 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757126Ab3C1QPL (ORCPT ); Thu, 28 Mar 2013 12:15:11 -0400 MIME-Version: 1.0 In-Reply-To: References: <1364444885-19751-1-git-send-email-yinghai@kernel.org> <1364444885-19751-2-git-send-email-yinghai@kernel.org> From: Bjorn Helgaas Date: Thu, 28 Mar 2013 10:14:51 -0600 Message-ID: Subject: Re: [PATCH 1/2] eisa, PCI: Fix bus res reference To: Yinghai Lu Cc: Linus Torvalds , Andrew Morton , Matthew Whitehead , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2793 Lines: 60 On Thu, Mar 28, 2013 at 9:16 AM, Yinghai Lu wrote: > On Thu, Mar 28, 2013 at 5:52 AM, Bjorn Helgaas wrote: >> On Wed, Mar 27, 2013 at 10:28 PM, Yinghai Lu wrote: >>> Matthem found that 3.8.3 is having problems with an old (ancient) >>> PCI-to-EISA bridge, the Intel 82375. It worked with the 3.2 kernel. >>> He identified the 82375, but doesn't assign the struct resource *res >>> pointer inside the struct eisa_root_device, and panics. >>> >>> After looking at pci_eisa_init(), found it referring bus resource >>> directly instead of pci_bus_resource_n(). >>> >>> After commit 45ca9e97 (PCI: add helpers for building PCI bus resource lists) >>> and commit 0efd5aab (PCI: add struct pci_host_bridge_window with CPU/bus >>> address offset), bus->resource[] is not used for pci root bus any more. >>> >>> Fix it by using pci_bus_resource_n() and correct idx for root bus. >> >> Please include URLs for the problem reports for these problems >> (bugzilla or mailing list discussion). > > Matthew sent private mail to me, and I sent him test patch to see > if it fixes the problem. then I posted patches here after that. Please add "cc: linux-pci@vger.kernel.org" when you respond to private mail like that. As far as I'm concerned, if it doesn't appear in a public email archive, it didn't happen. I hate dealing with patches out of the blue like this that don't have any context. If it's on a mailing list, other people with the same problem have some hope of finding this solution. >>> Reported-by: Matthew Whitehead >>> Tested-by: Matthew Whitehead >>> Signed-off-by: Yinghai Lu >>> Cc: stable@kernel.org >> >> You are consistently using the wrong stable email address. It should >> be "stable@vger.kernel.org". I assume you see a bounce every time; at >> least, I get a bounce when I reply to your messages. > > I thought that is tag only, and stable maintainer will search that from > Linus's tree. > but git send-mail will pick up Cc from the patch. > > So stable@kernel.org will never get fixed? What's to fix? The doc (Documentation/stable_kernel_rules.txt) says to use "Cc: stable@vger.kernel.org" and using "Cc: stable@kernel.org" causes bounces. Just use the documented address like everybody else and everything will be fine. If you want "stable@kernel.org" to work, first make the kernel.org change, then change Documentation/stable_kernel_rules.txt, *then* start using it in your patches. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/