Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753508Ab3C1SBp (ORCPT ); Thu, 28 Mar 2013 14:01:45 -0400 Received: from casper.infradead.org ([85.118.1.10]:35822 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360Ab3C1SBo (ORCPT ); Thu, 28 Mar 2013 14:01:44 -0400 Date: Thu, 28 Mar 2013 18:01:42 +0000 From: Thomas Graf To: Hong zhi guo Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller , stephen@networkplumber.org Subject: Re: [PATCH 1/6] net-next: replace obsolete NLMSG_* with type safe nlmsg_* Message-ID: <20130328180142.GJ23043@casper.infradead.org> References: <1364402824-32680-1-git-send-email-honkiko@gmail.com> <20130328143216.GC23043@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 26 On 03/29/13 at 12:08am, Hong zhi guo wrote: > Thanks, Thomas. But I didn't change any formatting. Just do the > substitution in place. Your change would require reformatting on the lines following your change because the required level of indentation changed. I don't want to cause you unneeded pain but it really helps everyone used to the kernel coding style. > >> - rep = alloc_skb(NLMSG_SPACE((sizeof(struct inet_diag_msg) + > >> - sizeof(struct inet_diag_meminfo) + > >> - 64)), GFP_KERNEL); > >> + rep = nlmsg_new(sizeof(struct inet_diag_msg) + > >> + sizeof(struct inet_diag_meminfo) + 64, > >> + GFP_KERNEL); ^^^^^^^^^^^^^^ > Should I re-format and re-send the patch? Yes please, just resubmit the patches that changed and include a proper vN in the subject. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/