Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753143Ab3C1SOo (ORCPT ); Thu, 28 Mar 2013 14:14:44 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:47321 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160Ab3C1SOn (ORCPT ); Thu, 28 Mar 2013 14:14:43 -0400 Date: Thu, 28 Mar 2013 18:14:26 +0000 From: Russell King - ARM Linux To: Jason Cooper Cc: Sebastian Hesselbarth , Andrew Lunn , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 Message-ID: <20130328181425.GE3368@n2100.arm.linux.org.uk> References: <1364051211-24414-1-git-send-email-sebastian.hesselbarth@gmail.com> <20130328170654.GX13280@titan.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130328170654.GX13280@titan.lakedaemon.net> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 32 On Thu, Mar 28, 2013 at 01:06:54PM -0400, Jason Cooper wrote: > On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > > iWMMXt extensions on Dove. > > > > Signed-off-by: Sebastian Hesselbarth > > --- > > Cc: Russell King > > Cc: Jason Cooper > > Cc: Andrew Lunn > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > --- > > arch/arm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hmmm, I'm getting (with dove_defconfig): > > arch/arm/kernel/built-in.o: In function `iwmmxt_do': > /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release' > /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch' > make: *** [vmlinux] Error 1 Looks to me like PJ4 IWMMXT support wasn't properly tested out when it was submitted - it's possible to end up with pj4-cp0.c built without the IWMMXT code that it depends on being built... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/