Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753439Ab3C1U7W (ORCPT ); Thu, 28 Mar 2013 16:59:22 -0400 Received: from mtaout03-winn.ispmail.ntl.com ([81.103.221.49]:54281 "EHLO mtaout03-winn.ispmail.ntl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299Ab3C1U7V (ORCPT ); Thu, 28 Mar 2013 16:59:21 -0400 X-Greylist: delayed 71848 seconds by postgrey-1.27 at vger.kernel.org; Thu, 28 Mar 2013 16:59:20 EDT Date: Thu, 28 Mar 2013 20:59:16 +0000 From: Ken Moffat To: linux-kernel@vger.kernel.org Cc: Gwendal Grignou , Jeff Garzik Subject: Re: smartd broken in 3.9.0-rc4 : bisected Message-ID: <20130328205916.GA18846@milliways> References: <20130328010148.GB25406@milliways> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130328010148.GB25406@milliways> User-Agent: Mutt/1.5.21 (2010-09-15) X-Cloudmark-Analysis: v=1.1 cv=AUhbpHVS+xhHrj9wLCYAQoYnFLYUZdbP8UM0GmH2jwk= c=1 sm=0 a=wom5GMh1gUkA:10 a=9l3l3-VRnGgA:10 a=uObrxnre4hsA:10 a=8nJEP1OIZ-IA:10 a=-9fLHVDCAAAA:8 a=1XWaLZrsAAAA:8 a=S10iBd1SXdJN2ODrGfUA:9 a=wPNLvfGTeEIA:10 a=UTB_XpHje0EA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3696 Lines: 90 On Thu, Mar 28, 2013 at 01:01:48AM +0000, Ken Moffat wrote: Adding Cc:s, further details at the end. > Hi, > > just tested my first 3.9 kernel today. During boot, smartd (from > smartmontools-6.0) fails to start. Works fine in 3.8.4. > > In 3.8.4 I get messages like this : > > Mar 27 22:02:02 ac4tv smartd[3981]: smartd 6.0 2012-10-10 r3643 > [x86_64-linux-3.8.4] (local build) > Mar 27 22:02:02 ac4tv smartd[3981]: Copyright (C) 2002-12, Bruce > Allen, Christian Franke, www.smartmontools.org > Mar 27 22:02:02 ac4tv smartd[3981]: Opened configuration file > /etc/smartd.conf > Mar 27 22:02:02 ac4tv smartd[3981]: Configuration file > /etc/smartd.conf parsed. > Mar 27 22:02:02 ac4tv smartd[3981]: Device: /dev/sda, opened > Mar 27 22:02:02 ac4tv smartd[3981]: Device: /dev/sda, WDC > WD5000AAKX-001CA0, S/N:WD-WMAYU6818967, WWN:5-0014ee-0ad9caed4, > FW:15.01H15, 500 GB > Mar 27 22:02:02 ac4tv smartd[3981]: Device: /dev/sda, found in > smartd database: Western Digital Caviar Blue Serial ATA > Mar 27 22:02:02 ac4tv smartd[3981]: Device: /dev/sda, enabled SMART > Automatic Offline Testing. > Mar 27 22:02:02 ac4tv smartd[3981]: Device: /dev/sda, is SMART > capable. Adding to "monitor" list. > Mar 27 22:02:02 ac4tv smartd[3981]: Monitoring 1 ATA and 0 SCSI > devices > > but in 3.9.0-rc4 all I get is > Mar 28 00:39:32 ac4tv smartd[2487]: Copyright (C) 2002-12, Bruce > Allen, Christian Franke, www.smartmontools.org > Mar 28 00:39:32 ac4tv smartd[2487]: Opened configuration file > /etc/smartd.conf > Mar 28 00:39:32 ac4tv smartd[2487]: Configuration file > /etc/smartd.conf parsed. > Mar 28 00:39:32 ac4tv smartd[2487]: Device: /dev/sda, opened > Mar 28 00:39:32 ac4tv smartd[2487]: Device: /dev/sda, WDC > WD5000AAKX-001CA0, S/N:WD-WMAYU6818967, WWN:5-0014ee-0ad9caed4, > FW:15.01H15, 500 GB > Mar 28 00:39:32 ac4tv smartd[2487]: Device: /dev/sda, found in > smartd database: Western Digital Caviar Blue Serial ATA > Mar 28 00:39:32 ac4tv smartd[2487]: Device: /dev/sda, could not > enable SMART capability > Mar 28 00:39:32 ac4tv smartd[2487]: Unable to register ATA device > /dev/sda at line 1 of file /etc/smartd.conf > Mar 28 00:39:32 ac4tv smartd[2487]: Unable to register device > /dev/sda (no Directive -d removable). Exiting. > > Using strace, in the failing version I get > 2643 ioctl(3, HDIO_DRIVE_CMD, 0x7fff53288a60) = -1 EIO (Input/output error) > > instead of the normal > 3981 ioctl(3, HDIO_DRIVE_CMD, 0x7fff04437340) = 0 > 3981 ioctl(3, HDIO_DRIVE_TASK, 0x7fff04437350) = 0 > 3981 ioctl(3, HDIO_DRIVE_CMD, 0x7fff04437330) = 0 > 3981 ioctl(3, HDIO_DRIVE_CMD, 0x7fff04437330) = 0 > 3981 ioctl(3, HDIO_DRIVE_TASK, 0x7fff04437340) = 0 > > Looks like I'll be bisecting. > > ken Bisection blames : commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 Author: Gwendal Grignou Date: Fri Jan 18 10:56:43 2013 -0800 [libata] Set proper SK when CK_COND is set. When the user application sends a ATA_12 or ATA_16 PASSTHROUGH scsi command, put the task file register in the sense data with the proper Sense Key. Instead of NO SENSE, set RECOVERED, as specified in [SAT2]12.2.5 Table 92. That reverts cleanly from 3.9.0-rc4, and with it reverted smartd works again. Obviously that does nothing to fix whatever problem this was supposed to fix. I can test any follow-up patches if needed. ken -- das eine Mal als Trag?die, das andere Mal als Farce -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/