Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755134Ab3C2C4n (ORCPT ); Thu, 28 Mar 2013 22:56:43 -0400 Received: from mail-vc0-f170.google.com ([209.85.220.170]:44475 "EHLO mail-vc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753800Ab3C2C4l (ORCPT ); Thu, 28 Mar 2013 22:56:41 -0400 MIME-Version: 1.0 In-Reply-To: <1364507705-22012-3-git-send-email-arnd@arndb.de> References: <1364507705-22012-1-git-send-email-arnd@arndb.de> <1364507705-22012-3-git-send-email-arnd@arndb.de> Date: Fri, 29 Mar 2013 08:26:41 +0530 X-Google-Sender-Auth: VZYIjaBurHGT7UkzJrnng8HWgQk Message-ID: Subject: Re: [PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver From: Viresh Kumar To: Arnd Bergmann Cc: Alan Stern , linux-usb@vger.kernel.org, Manjunath Goudar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg KH , Deepak Saxena , Shiraz Hashim , spear-devel@list.st.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1792 Lines: 42 On Fri, Mar 29, 2013 at 3:25 AM, Arnd Bergmann wrote: > From: Manjunath Goudar > > Separate the SPEAr host controller driver from ehci-hcd host code > so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM; > however, note that other changes are still needed before SPEAr can be > booted with a multi-platform kernel, but they are queued in the > arm-soc tree for 3.10. > > With the infrastructure added by Alan Stern in patch 3e0232039 > "USB: EHCI: prepare to make ehci-hcd a library module", we can > avoid this problem by turning a bus glue into a separate > module, as we do here for the SPEAr bus glue. > > In V3: > -Detailed commit message added here about why this patch is required. > -Eliminated ehci_spear_setup routine beacuse hcd registers > directly setting in spear_ehci_hcd_drv_probe function. > -spear_overrides struct initialized. > -Eliminate struct ehci_hcd ehci from struct spear_ehci,to enable SPEAr clock > uses directly usb_hcd *hcd in spear_start_ehci function. > -to_spear_ehci() macro modified for spear_ehci. > > In V2: > Replaced spear as SPEAr everywhere, leaving functions/variables/config options. > > Signed-off-by: Deepak Saxena > Signed-off-by: Manjunath Goudar > Signed-off-by: Arnd Bergmann > Acked-by: Viresh Kumar This version has changed from what i Acked, but it still looks fine. Thanks. Viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/