Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754701Ab3C2Dve (ORCPT ); Thu, 28 Mar 2013 23:51:34 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:60222 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754412Ab3C2Dvc (ORCPT ); Thu, 28 Mar 2013 23:51:32 -0400 Date: Thu, 28 Mar 2013 20:51:25 -0700 From: "Paul E. McKenney" To: Paul Gortmaker Cc: Frederic Weisbecker , Ingo Molnar , LKML , Andrew Morton , Chris Metcalf , Christoph Lameter , Geoff Levand , Gilad Ben Yossef , Hakan Akkan , Kevin Hilman , Li Zhong , Namhyung Kim , Peter Zijlstra , Steven Rostedt , Thomas Gleixner Subject: Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot Message-ID: <20130329035124.GM3337@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1364398359-21990-1-git-send-email-fweisbec@gmail.com> <1364398359-21990-3-git-send-email-fweisbec@gmail.com> <20130328074045.GB24433@gmail.com> <20130329002555.GA3444@windriver.com> <20130329020054.GK3337@linux.vnet.ibm.com> <20130329020822.GD3444@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130329020822.GD3444@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13032903-3620-0000-0000-000001D1B6E4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2536 Lines: 51 On Thu, Mar 28, 2013 at 10:08:23PM -0400, Paul Gortmaker wrote: > [Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot] On 28/03/2013 (Thu 19:00) Paul E. McKenney wrote: > > > On Fri, Mar 29, 2013 at 01:39:04AM +0100, Frederic Weisbecker wrote: > > > 2013/3/29 Paul Gortmaker : > > > > [Re: [PATCH 2/4] nohz: Print final full dynticks CPUs range on boot] On 28/03/2013 (Thu 08:40) Ingo Molnar wrote: > > > > > > > >> > > > >> * Frederic Weisbecker wrote: > > > >> > > > >> > + cpulist_scnprintf(nohz_ext_buf, sizeof(nohz_ext_buf), nohz_extended_mask); > > > >> > + pr_info("NO_HZ: Experimental full dynticks CPUs: %s.\n", nohz_ext_buf); > > > >> > > > >> I'd suggest removing the 'experimental' word. We are not sending anything > > > >> experimental to Linus: we'll send something that is tested and that we > > > >> expect to not break anything. (and which we'll fix if it does) > > > > > > > > In that case, should we vector a patch through PaulM to clobber these too? > > > > > > > > $ git grep xperiment |grep rcu > > > > kernel/rcutree_plugin.h: printk(KERN_INFO "\tExperimental boot-time adjustment of leaf fanout to %d.\n", rcu_fanout_leaf); > > > > This one has been this way for quite some time. I must confess that I am > > more inclined to remove this Kconfig option entirely than I am to remove > > the "Experimental". ;-) > > > > > > kernel/rcutree_plugin.h: pr_info("\tExperimental no-CBs CPUs: %s.\n", nocb_buf); > > > > kernel/rcutree_plugin.h: pr_info("\tExperimental polled no-CBs CPUs.\n"); > > > > > > Hehe, that's indeed what I inspired from ;-) > > > > I guess we can rerun the earlier "how to mark Kconfig options as not > > yet being ready for 100 million unsuspecting victims^Wusers. ;-) > > Perhaps consider "hiding" these kinds of choices behind CONFIG_EXPERT ? We tried that with CONFIG_EXPERIMENTAL (or something like that), and what happened was that all distros eventually enabled CONFIG_EXPERIMENTAL. But if I was -really- serious about keeping the testing population down, I would take Matthew Garret's advice and force a splat during boot-up. So I now have a commit for 3.11 queued to remove the "Experimental" from these strings, with your Reported-by. Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/