Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754744Ab3C2GVO (ORCPT ); Fri, 29 Mar 2013 02:21:14 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:54543 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754020Ab3C2GVM (ORCPT ); Fri, 29 Mar 2013 02:21:12 -0400 X-IronPort-AV: E=Sophos;i="4.87,371,1363129200"; d="scan'208";a="9128268" Date: Fri, 29 Mar 2013 07:21:07 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Luis R. Rodriguez" cc: Julia Lawall , Jesse Barnes , florianschandinat , linux-fbdev , dri-devel@lists.freedesktop.org, "backports@vger.kernel.org" , cocci@systeme.lip6.fr, "linux-kernel@vger.kernel.org" , "rodrigo.vivi" , Daniel Vetter , "rafael.j.wysocki" Subject: Re: [PATCH] compat/compat-drivers/linux-next: fb skip_vt_switch In-Reply-To: Message-ID: References: <1364472270-9297-1-git-send-email-mcgrof@do-not-panic.com> <20130328083943.01e61b4b@jbarnes-desktop> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 17 > > I looked in today's linux-next, and there seems to be only one > > initialization of this field, to true, and one test of this field. So > > perhaps the case for setting the field to false just isn't needed. > > Oh sorry now I get what you mean! I thought about this -- and yes I > decided to not add a bool false setting for the structure field given > that the assumption is this would not be something dynamic, and data > structure would be kzalloc()'d so by default they are 0. What do you do about the test, though? julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/