Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755217Ab3C2HaK (ORCPT ); Fri, 29 Mar 2013 03:30:10 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:55053 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753431Ab3C2HaH (ORCPT ); Fri, 29 Mar 2013 03:30:07 -0400 MIME-Version: 1.0 In-Reply-To: References: <1364472270-9297-1-git-send-email-mcgrof@do-not-panic.com> <20130328083943.01e61b4b@jbarnes-desktop> From: "Luis R. Rodriguez" Date: Fri, 29 Mar 2013 00:29:44 -0700 X-Google-Sender-Auth: Jd4C-ktBfnXrNm-xx5KrQ9l1juM Message-ID: Subject: Re: [PATCH] compat/compat-drivers/linux-next: fb skip_vt_switch To: Julia Lawall Cc: Jesse Barnes , florianschandinat , linux-fbdev , dri-devel@lists.freedesktop.org, "backports@vger.kernel.org" , cocci@systeme.lip6.fr, "linux-kernel@vger.kernel.org" , "rodrigo.vivi" , Daniel Vetter , "rafael.j.wysocki" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 20 On Thu, Mar 28, 2013 at 11:21 PM, Julia Lawall wrote: >> > I looked in today's linux-next, and there seems to be only one >> > initialization of this field, to true, and one test of this field. So >> > perhaps the case for setting the field to false just isn't needed. >> >> Oh sorry now I get what you mean! I thought about this -- and yes I >> decided to not add a bool false setting for the structure field given >> that the assumption is this would not be something dynamic, and data >> structure would be kzalloc()'d so by default they are 0. > > What do you do about the test, though? Return the value. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/