Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756527Ab3C2RbR (ORCPT ); Fri, 29 Mar 2013 13:31:17 -0400 Received: from mga14.intel.com ([143.182.124.37]:37496 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756499Ab3C2RbN (ORCPT ); Fri, 29 Mar 2013 13:31:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,374,1363158000"; d="scan'208";a="277700819" Message-ID: <5155CFDE.2070703@intel.com> Date: Fri, 29 Mar 2013 10:31:10 -0700 From: Dave Jiang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Dan Williams CC: vinod.koul@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] ioatdma: Removing PQ val disable for cb3.3 References: <20130326223953.15072.26605.stgit@djiang5-linux2.ch.intel.com> <20130326224309.15072.83839.stgit@djiang5-linux2.ch.intel.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2336 Lines: 54 On 03/27/2013 11:48 AM, Dan Williams wrote: > On Tue, Mar 26, 2013 at 3:43 PM, Dave Jiang wrote: >> The PQ Val ops work on the newer hardware so we should actually provide support >> for it and remove the disabling bits. >> >> Signed-off-by: Dave Jiang >> --- >> drivers/dma/Kconfig | 2 - >> drivers/dma/ioat/dma.h | 1 >> drivers/dma/ioat/dma_v3.c | 134 ++++++++++++++++++++++++++++++++++++++---- >> drivers/dma/ioat/registers.h | 2 + >> 4 files changed, 125 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig >> index 80b6997..dec088d 100644 >> --- a/drivers/dma/Kconfig >> +++ b/drivers/dma/Kconfig >> @@ -63,8 +63,6 @@ config INTEL_IOATDMA >> depends on PCI && X86 >> select DMA_ENGINE >> select DCA >> - select ASYNC_TX_DISABLE_PQ_VAL_DMA >> - select ASYNC_TX_DISABLE_XOR_VAL_DMA >> help >> Enable support for the Intel(R) I/OAT DMA engine present >> in recent Intel Xeon chipsets. > [..] >> @@ -1469,15 +1581,13 @@ int ioat3_dma_probe(struct ioatdma_device *device, int dca) >> device->cleanup_fn = ioat3_cleanup_event; >> device->timer_fn = ioat3_timer_event; >> >> - #ifdef CONFIG_ASYNC_TX_DISABLE_PQ_VAL_DMA >> - dma_cap_clear(DMA_PQ_VAL, dma->cap_mask); >> - dma->device_prep_dma_pq_val = NULL; >> - #endif >> + if (is_xeon_cb32(pdev)) { >> + dma_cap_clear(DMA_XOR_VAL, dma->cap_mask); >> + dma->device_prep_dma_xor_val = NULL; >> >> - #ifdef CONFIG_ASYNC_TX_DISABLE_XOR_VAL_DMA >> - dma_cap_clear(DMA_XOR_VAL, dma->cap_mask); >> - dma->device_prep_dma_xor_val = NULL; >> - #endif >> + dma_cap_clear(DMA_PQ_VAL, dma->cap_mask); >> + dma->device_prep_dma_pq_val = NULL; >> + } > Note that this effectively disables raid offload for is_xeon_cb32() > platforms since DMA_ASYNC_TX will not be set. We are ok with that until a workaround can be figured out. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/