Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756611Ab3C2RtR (ORCPT ); Fri, 29 Mar 2013 13:49:17 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:48375 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756092Ab3C2RtQ (ORCPT ); Fri, 29 Mar 2013 13:49:16 -0400 Date: Fri, 29 Mar 2013 13:49:15 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Arnd Bergmann cc: linux-usb@vger.kernel.org, Manjunath Goudar , , , Greg KH , Russell King Subject: Re: [PATCH v3 1/7] USB: EHCI: make ehci-orion a separate driver In-Reply-To: <1364507705-22012-2-git-send-email-arnd@arndb.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 43 On Thu, 28 Mar 2013, Arnd Bergmann wrote: > From: Manjunath Goudar > > Separate the Orion host controller driver from ehci-hcd host > code into its own driver module because of following reason. ... On the whole this patch is good. > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -163,6 +163,16 @@ config USB_EHCI_HCD_OMAP > Enables support for the on-chip EHCI controller on > OMAP3 and later chips. > > +config USB_EHCI_HCD_ORION > + tristate "Support for Marvell EBU on-chip EHCI USB controller" > + depends on USB_EHCI_HCD && PLAT_ORION > + default y > + ---help--- > + Enables support for the on-chip EHCI controller on Marvell's > + embedded ARM SoCs, including Orion, Kirkwood, Dove, Armada XP, > + Armada 370. This is different from the EHCI implementation > + on Marvell's mobile PXA and MMP SoC, see USB_EHCI_MV for those. I don't know about this last phrase. When someone is running "make menuconfig", for example, what shows up is the symbol's description, not the symbol's name. That person would see "EHCI support for Marvell on-chip controller", not "USB_EHCI_MV". In fact, shouldn't the description for USB_EHCI_MV be changed too, to make it more distinct from this one? All the code changes are fine. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/