Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756770Ab3C2SKz (ORCPT ); Fri, 29 Mar 2013 14:10:55 -0400 Received: from smtp.citrix.com ([66.165.176.89]:47266 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756522Ab3C2SKy (ORCPT ); Fri, 29 Mar 2013 14:10:54 -0400 X-IronPort-AV: E=Sophos;i="4.87,374,1363132800"; d="scan'208";a="16428519" Date: Fri, 29 Mar 2013 18:10:48 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Nicolas Pitre CC: Stefano Stabellini , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Will Deacon , Arnd Bergmann , "marc.zyngier@arm.com" , Russell King - ARM Linux Subject: Re: [PATCH v4 2/2] arm: prefer PSCI for SMP bringup In-Reply-To: Message-ID: References: <1364575371-8926-2-git-send-email-stefano.stabellini@eu.citrix.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1915 Lines: 47 On Fri, 29 Mar 2013, Nicolas Pitre wrote: > On Fri, 29 Mar 2013, Stefano Stabellini wrote: > > > On Fri, 29 Mar 2013, Nicolas Pitre wrote: > > > This way the > > > priority order would be: > > > > > > - If mdesc->smp_init is non null then use that. > > > > > > - Otherwise, if PSCI is available then use that. > > > > > > - Otherwise use mdesc->smp. > > > > > > This way, if the PSCI default has to be overriden (like in the MCPM case > > > because it needs to wrap PSCI itself, or to cover Rob's concern) then > > > this can be achieved at run time on a per mdesc basis. > > > > Actually that's not a bad idea, it could make everybody happy. > > What about the following, in this precise order: > > > > - if a xen hypervisor node is present on device tree, use PSCI; > > - otherwise if mdesc->smp_init is non null then use it; > > - otherwise if PSCI is available then use it; > > - otherwise use mdesc->smp. > > > > It's the most practical solution to satisfy everybody's needs. > > Regardless of my previous email suggesting a mdesc for xen, I still > don't understand why you need this absolute priority for Xen. Isn't my > original suggestion sufficient? > > The likely reason why mdesc->smp_init might be needed is to provide an > extra encapsulation layer before actually using PSCI instead of using it > directly. Why would you need to bypass that? Uhm.. maybe I wouldn't, I am not 100% sure TBH. I am expecting that this "extra encapsulation layer" would read/write some platform specific registers that Xen doesn't export. If this is the case, then we would need to bypass it. But if it's just to mangle parameters, then it should be OK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/