Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756980Ab3C2Tla (ORCPT ); Fri, 29 Mar 2013 15:41:30 -0400 Received: from mail-we0-f176.google.com ([74.125.82.176]:52468 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756675Ab3C2Tl2 (ORCPT ); Fri, 29 Mar 2013 15:41:28 -0400 MIME-Version: 1.0 X-Originating-IP: [2001:470:1f05:1640:47c:d90f:eea8:ac64] In-Reply-To: <5155C9C6.4070702@wwwdotorg.org> References: <20130306193332.GA6022@amd.pavel.ucw.cz> <5137C404.9060902@wwwdotorg.org> <20130307144506.GB7344@amd.pavel.ucw.cz> <5138FDAE.8060202@wwwdotorg.org> <20130311050546.GA21863@quad.lixom.net> <20130328092916.GA11187@amd.pavel.ucw.cz> <51545870.4010209@wwwdotorg.org> <20130328193323.GA25166@amd.pavel.ucw.cz> <20130328195456.GA22527@quad.lixom.net> <5155C9C6.4070702@wwwdotorg.org> Date: Fri, 29 Mar 2013 12:41:27 -0700 Message-ID: Subject: Re: 3.9-rc1 regression in arm dtb build From: Olof Johansson To: Stephen Warren Cc: Pavel Machek , Grant Likely , kernel list , "Rafael J. Wysocki" , Russell King - ARM Linux , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Rob Herring , Linus Torvalds Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2494 Lines: 66 On Fri, Mar 29, 2013 at 10:05 AM, Stephen Warren wrote: > On 03/28/2013 01:54 PM, Olof Johansson wrote: >> On Thu, Mar 28, 2013 at 08:33:23PM +0100, Pavel Machek wrote: >>> On Thu 2013-03-28 08:49:20, Stephen Warren wrote: >>>> On 03/28/2013 03:29 AM, Pavel Machek wrote: >>>> ... >>>>> There's change that makes it pretty much impossible to build dtbs >>>>> reliably between different kernel versions, because it leaves old dtbs >>>>> around, and they survive even make clean. >>>> >>>> One question here: Presumably the dtbs don't survive "make clean" if you >>>> run that right after building the dtbs, but only if you check out a new >>>> kernel version before running clean? Or is that not the case? >>> >>> That was the case I seen, yes. >>> >>> Have old kernel running, dtbs building. Apply a patch. It starts >>> behaving weird. You do make clean... but you still get old dtbs. >>> >>> (It would be nice if make socfpga_cyclone5.dtb would magically remove >>> all the dtbs from old location; make dtbs does that if I understand >>> stuff correctly). >> >> >> This takes care of the "make dtbs" case (or just "make" case), but not >> when you build a specific target. > > I guess to really solve this, we need the following changes: > > In the all kernels: > > For both arch/*/boot and arch/*/boot/dts: clean removes *.dtb > > In kernels that build *.dtb in the new location: > > make dtbs and make foo.dtb both rm ../*.dtb I don't think this is useful. If you're building a specific dtb target, there should be no expectation that other dtb files should automatically be removed. The original complaint was that make clean didn't remove the old dtb files. That's been resolved with the provided patch. I don't think it's worth the hassle of trying to remove ../foo.dtb. > In kernels that build *.dtb in the old location: > > make dtbs and make foo.dtb both rm dts/*.dtb > > Is that too much to retrofit into all the stable kernels? I also don't think this is worth the effort. If you're going to check out old and new kernels in the same tree, you should probably get into the habit of using git clean. Perhaps we need a "dtb_install" target instead, so people stop copying from the source directories. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/