Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756504Ab3C3Jzn (ORCPT ); Sat, 30 Mar 2013 05:55:43 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:45554 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755206Ab3C3Jzm (ORCPT ); Sat, 30 Mar 2013 05:55:42 -0400 MIME-Version: 1.0 In-Reply-To: <1364621848.3568.0.camel@phoenix> References: <1364621848.3568.0.camel@phoenix> Date: Sat, 30 Mar 2013 15:25:41 +0530 Message-ID: Subject: Re: [PATCH v2] pwm: spear: Fix enable pwm output From: Viresh Kumar To: Axel Lin Cc: Thierry Reding , Shiraz Hashim , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 18 On 30 March 2013 11:07, Axel Lin wrote: > The logic to check return value of clk_enable() is reversed, thus > when clk_enable() passes PWMCR_PWM_ENABLE bit is not set. Fix it. > > Signed-off-by: Axel Lin > --- > drivers/pwm/pwm-spear.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I am so sorry. clk_prepare also has the same issue :( Please fix that too and i will ack it ASAP. @Shiraz: Any idea how they went through? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/