From: Marek Vasut <marek.vasut@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Subject: Re: gpio-ucb1400
Date: Sat, 30 Mar 2013 20:20:44 +0100
User-Agent: KMail/1.13.7 (Linux/3.8-trunk-amd64; KDE/4.8.4; x86_64; ; )
Cc: Jean Delvare <jdelvare@suse.de>,
        "linux-kernel" <linux-kernel@vger.kernel.org>,
        Grant Likely <grant.likely@secretlab.ca>,
        Linus Walleij <linus.walleij@linaro.org>
References: <1364586399.4216.312.camel@amber.site> <20130330151037.GA359@roeck-us.net>
In-Reply-To: <20130330151037.GA359@roeck-us.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201303302020.44584.marek.vasut@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1672
Lines: 40

Dear Guenter Roeck,

> On Fri, Mar 29, 2013 at 08:46:39PM +0100, Jean Delvare wrote:
> > Hi all,
> > 
> > In September 2009, a driver for the GPIO function of the UCB1400 chip
> > was added to the kernel tree. The probe function of this driver requires
> > ucbdata to be set. The only place where this happens is in function
> > ucb1400_gpio_set_data(). This function was never call, and still isn't.
> > So this is dead code for 3.5 years as far as the upstream kernel is
> > concerned.
> > 
> > To make things worse, this driver can't be built as a module, for no
> > good reason that I can see.
> > 
> > Marek, can you explain what was the point of submitting this driver that
> > nobody can use?
> > 
> > I would like either this driver to be fixed so that it can be used (and
> > that would IMHO start with dropping the ugly ucb1400_gpio_set_data hook
> > and global variable ucbdata), or this driver to be dropped from the
> > kernel tree. If the driver is kept, it should be adjusted so that it can
> > be built as a module.
> > 
> > If I overlooked something, please let me know.
> 
> Interestingly, the author made an attempt to fix that with [1]. It looks
> like the rest of that series was merged, but this patch wasn't, though I
> don't find any information about the reason.

It's been a while. Guenter, thanks for finding that link, but I suspect the 
patch is heavily obsolete by now.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/