Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758675Ab3DAJjc (ORCPT ); Mon, 1 Apr 2013 05:39:32 -0400 Received: from mail-ee0-f41.google.com ([74.125.83.41]:59693 "EHLO mail-ee0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758660Ab3DAJjb (ORCPT ); Mon, 1 Apr 2013 05:39:31 -0400 Date: Mon, 1 Apr 2013 11:39:27 +0200 From: Michal Hocko To: Li Zefan Cc: Glauber Costa , KAMEZAWA Hiroyuki , Johannes Weiner , LKML , Cgroups , linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH] memcg: avoid accessing memcg after releasing reference Message-ID: <20130401093927.GB30749@dhcp22.suse.cz> References: <5158F344.9020509@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5158F344.9020509@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 44 On Mon 01-04-13 10:39:00, Li Zefan wrote: > This might cause use-after-free bug. > > Signed-off-by: Li Zefan Acked-by: Michal Hocko > --- > > found when reading the code. > > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 8ec501c..6391046 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3186,12 +3186,12 @@ void memcg_release_cache(struct kmem_cache *s) > > root = s->memcg_params->root_cache; > root->memcg_params->memcg_caches[id] = NULL; > - mem_cgroup_put(memcg); > > mutex_lock(&memcg->slab_caches_mutex); > list_del(&s->memcg_params->list); > mutex_unlock(&memcg->slab_caches_mutex); > > + mem_cgroup_put(memcg); > out: > kfree(s->memcg_params); > } > -- > 1.8.0.2 -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/