Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757724Ab3DAR2z (ORCPT ); Mon, 1 Apr 2013 13:28:55 -0400 Received: from mail-ob0-f170.google.com ([209.85.214.170]:51178 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756913Ab3DAR2v (ORCPT ); Mon, 1 Apr 2013 13:28:51 -0400 MIME-Version: 1.0 In-Reply-To: <5148886F.8000809@googlemail.com> References: <51016937.1020202@googlemail.com> <51053917.6060400@fold.natur.cuni.cz> <5105491E.9050907@googlemail.com> <510558CE.9000600@fold.natur.cuni.cz> <5105AFDB.9000200@googlemail.com> <5105E51D.2020606@huawei.com> <51064F1A.1020909@googlemail.com> <51065FA6.4070208@googlemail.com> <51066B46.10409@fold.natur.cuni.cz> <5106CD6C.4070009@googlemail.com> <5106E770.9070602@fold.natur.cuni.cz> <510A5F0E.6010100@googlemail.com> <5138C03C.8080600@googlemail.com> <5138F6B6.8050208@googlemail.com> <5139C0F7.9030907@googlemail.com> <513AFECB.40409@googlemail.com> <5148886F.8000809@googlemail.com> From: Bjorn Helgaas Date: Mon, 1 Apr 2013 11:28:29 -0600 Message-ID: Subject: Re: 3.8.0-rc4+ - Oops on removing WinTV-HVR-1400 expresscard TV Tuner To: Chris Clayton Cc: Martin Mokrejs , Yijing Wang , Yijing Wang , LKML , "linux-pci@vger.kernel.org" , "Rafael J. Wysocki" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3287 Lines: 83 On Tue, Mar 19, 2013 at 9:46 AM, Chris Clayton wrote: > Hi Bjorn, > > Sorry I meant to reply to your mail so that copy recipients will know the > outcome of the things you asked me to do. But then I forgot. Doh! You should > have received the attachment notification from bugzilla, I think. > > > On 03/15/13 22:48, Bjorn Helgaas wrote: >> >> On Tue, Mar 12, 2013 at 4:20 PM, Bjorn Helgaas >> wrote: >>> >>> On Sat, Mar 9, 2013 at 2:20 AM, Chris Clayton >>> wrote: >>>> >>>> On 03/08/13 22:57, Bjorn Helgaas wrote: >> >> >>>>> Thanks. I opened this bug report: >>>>> https://bugzilla.kernel.org/show_bug.cgi?id=54981 to keep track of >>>>> your logs. >> >> >> Hi Chris, >> >> The current Linux acpiphp driver doesn't do anything unless it finds >> devices with _EJ0 or _RMV methods, and your DSDT has neither. But I >> think that implementation is incorrect because I'm not convinced that >> those methods are required in order to do hotplug via ACPI. For >> example, your DSDT *does* have an _L01 method that does notifications >> to the root ports. I suspect that hotplug events on your box generate >> an SCI that invokes that method. Linux basically ignores the >> resulting notify events, and I suspect that hotplug works on Windows >> because it is paying attention to them. >> >> Can you build a kernel with CONFIG_ACPI_DEBUG=y, do the following, and >> attach all the output to the bugzilla? >> >> 1) Boot with empty ExpressCard slot (without using "pcie_ports=native") >> 2) # echo 0x00010004 > /sys/module/acpi/parameters/debug_layer >> 3) # echo 0x08000004 > /sys/module/acpi/parameters/debug_level >> 4) # lspci -vv >> 5) # setpci -s 1c.3 0x42.w >> 6) # setpci -s 1c.3 0x5a.w >> 7) # setpci -s 1c.3 0xd8.l >> 8) Insert ExpressCard >> 9) # setpci -s 1c.3 0x5a.w >> 10) # dmesg >> >> Here's what I think we'll see: >> >> - Slot Implemented (bit 8 of XCAP at 0x42) set, indicating a slot is >> implemented below this root port >> - Hot Plug SCI Enable (bit 30 of MPC at 0xd8) set, indicating that the >> root port should generate an SCI whenever a hotplug event is detected >> - Presence Detect State (bit 6 of SLTSTS at 0x5a) change from 0 with >> the slot empty to 1 with the slot occupied >> - pciehp doing nothing (since _OSC didn't grant the OS permission to >> use PCIe native hotplug) >> - dmesg indication of the SCI, leading to a Bus Check notification to >> \_SB.PCI0.RP04, which is the 1c.3 root port leading to the ExpressCard >> slot >> > > As far as I can see, your predicted outcomes where correct. I've added the > logs to the bugzilla report. Yes, it behaved exactly as I expected. I attached a few more details of the analysis to the bug report (https://bugzilla.kernel.org/show_bug.cgi?id=54981). I think we need to rework acpiphp to fix this. We will fix it, but I don't know who will do it, or when it will happen. My list is growing faster than I can deal with :( Thanks very much for your excellent data collection! Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/